Skip to content

Commit f02168a

Browse files
committed
Part of ##656
1 parent abd2e62 commit f02168a

File tree

3 files changed

+8
-21
lines changed

3 files changed

+8
-21
lines changed

server/src/main/java/invite/api/InvitationController.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import invite.exception.InvitationEmailMatchingException;
55
import invite.exception.InvitationExpiredException;
66
import invite.exception.InvitationStatusException;
7-
import invite.exception.InvitationUniqueCrmOrganisationException;
87
import invite.exception.NotFoundException;
8+
import invite.exception.RemoteException;
99
import invite.logging.AccessLogger;
1010
import invite.logging.Event;
1111
import invite.mail.MailBox;
@@ -574,12 +574,12 @@ private void checkCrmUniqueOrganisation(User user, Invitation invitation) {
574574
}
575575
});
576576
if (throwException.get()) {
577-
throw new InvitationUniqueCrmOrganisationException(
578-
String.format("User %s is not allowed to accept an invitation from Organisation %s, because it already has roles for Organisation %s",
577+
throw new RemoteException(HttpStatus.NOT_ACCEPTABLE,
578+
String.format("User %s with CRM contactID %s is not allowed to accept an invitation from Organisation %s, check the database for constraint violations",
579579
user.getEmail(),
580-
invitation.getCrmOrganisationId(),
581-
userCrmOrganisationId
582-
));
580+
user.getCrmContactId(),
581+
invitation.getCrmOrganisationId()
582+
), null);
583583
}
584584
}
585585
}

server/src/main/java/invite/exception/InvitationUniqueCrmOrganisationException.java

Lines changed: 0 additions & 13 deletions
This file was deleted.

server/src/test/java/invite/api/InvitationControllerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ void acceptWithCRMConstraint() throws Exception {
355355
.body(acceptInvitation)
356356
.post("/api/v1/invitations/accept")
357357
.then()
358-
.statusCode(HttpStatus.NOT_ACCEPTABLE.value());
358+
.statusCode(HttpStatus.BAD_REQUEST.value());
359359
}
360360

361361
@Test
@@ -378,7 +378,7 @@ void acceptWithCRMConstraintDuplicateProfile() throws Exception {
378378
.body(acceptInvitation)
379379
.post("/api/v1/invitations/accept")
380380
.then()
381-
.statusCode(HttpStatus.NOT_ACCEPTABLE.value());
381+
.statusCode(HttpStatus.BAD_REQUEST.value());
382382
}
383383

384384
@Test

0 commit comments

Comments
 (0)