Fixes #585 and bugfix for required short_name in update Role

Author: oharsta

server/src/main/java/invite/model/Role.java

@@ -30,7 +30,6 @@ public class Role implements Serializable, Provisionable {
     private String name;
 
     @Column(name = "short_name")
-    @NotNull
     private String shortName;
 
     @Column(name = "description")

server/src/main/java/invite/provision/scim/GroupURN.java

@@ -15,7 +15,7 @@ public static String sanitizeRoleShortName(String shortName) {
                 .trim()
                 .replaceAll(" +", " ")
                 .replaceAll(" ", "_")
-                .replaceAll("[^A-Za-z0-9_./]", "")
+                .replaceAll("[^A-Za-z0-9_./-]", "")
                 .replaceAll("_+", "_")
                 .toLowerCase();
         return normalizedShortName.endsWith("_") ? normalizedShortName.substring(0, normalizedShortName.length() - 1) : normalizedShortName;

server/src/test/java/invite/provision/scim/GroupURNTest.java

@@ -18,6 +18,9 @@ void sanitizeRoleShortName() {
 
         String sanitizedName = GroupURN.sanitizeRoleShortName("request/path &^");
         assertEquals("request/path", sanitizedName);
+
+        String sanitizedNameWithHyphen = GroupURN.sanitizeRoleShortName("request-path &^");
+        assertEquals("request-path", sanitizedNameWithHyphen);
     }
 
     @Test