Skip to content

Commit 1364c4a

Browse files
committed
Fixed S3 cache-control headers
1 parent ee634d6 commit 1364c4a

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

server/src/main/java/access/api/S3Storage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ public class S3Storage {
3131
private final String s3URL;
3232
private final ObjectMapper objectMapper;
3333
private final S3Client s3Client;
34-
private final Map<String, String> metadata = Map.of("Cache-Control", "max-age=31536000, public");
3534
private boolean bucketExists;
3635

3736
@SneakyThrows
@@ -81,7 +80,7 @@ public String uploadFile(String content) {
8180
.bucket(bucketName)
8281
.key(uuid)
8382
.contentType("image/jpeg")
84-
.metadata(metadata)
83+
.cacheControl("public, max-age=31536000, immutable")
8584
.build(),
8685
RequestBody.fromInputStream(inputStream, inputStream.available()));
8786

server/src/main/resources/application.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ config:
106106
descriptionEN: "Een test-IdP met <a href='https://idp.diy.surfconext.nl/showusers.php' target='_blank'>fictieve gebruikersaccounts</a>. De metadata vind je <a href='https://idp.diy.surfconext.nl/saml2/idp/metadata.php' target='_blank'>hier</a>"
107107
descriptionNL: "Een test-IdP met <a href='https://idp.diy.surfconext.nl/showusers.php' target='_blank'>fictieve gebruikersaccounts</a>. De metadata vind je <a href='https://idp.diy.surfconext.nl/saml2/idp/metadata.php' target='_blank'>hier</a>"
108108
idp_proxy_meta_data: https://metadata.test2.surfconext.nl/idp-metadata.xml
109+
minimal_stepup_acr_level: "http://test2.surfconext.nl/assurance/loa2"
109110
features:
110111
- name: idp
111112
enabled: true
@@ -119,7 +120,6 @@ config:
119120
- "http://test2.surfconext.nl/assurance/loa1.5"
120121
- "http://test2.surfconext.nl/assurance/loa2"
121122
- "http://test2.surfconext.nl/assurance/loa3"
122-
minimal_stepup_acr_level: "http://test2.surfconext.nl/assurance/loa2"
123123

124124
eduid-idp-entity-id: "https://login.test2.eduid.nl, https://localhost.surf.id"
125125

0 commit comments

Comments
 (0)