BSR error handling

Author: oharsta

client/src/connection/ChangeRequests.jsx

@@ -141,8 +141,6 @@ export const ChangeRequests = ({
             case actions.changed:
             case actions.array_changed:
                 return formatLogicalValue(attribute, change, isOld ? change.oldValue : change.newValue);
-            default:
-                throw new Error(`Unknown action ${change.type}`)
         }
     }
 

client/src/organization/UserManagement.jsx

@@ -87,8 +87,6 @@ export const UserManagement = () => {
                                              currentUserAuthority={currentUserAuthority}
                                              setRefresh={setRefresh}/>;
             }
-            default:
-                throw new Error(`Unknown tab; ${currentTab}`)
         }
     }
 

client/src/pages/ApplicationDetail.jsx

@@ -337,8 +337,6 @@ const ApplicationDetail = ({anonymous, refreshUser}) => {
             case  "information": {
                 return renderInformation();
             }
-            default:
-                throw new Error(`Unknown tab; ${currentTab}`)
         }
     }
 

client/src/pages/Connection.jsx

@@ -253,8 +253,6 @@ export const Connection = () => {
                                           refresh={refresh}
                 />
             }
-            default:
-                throw new Error(`Unknown tab; ${currentTab}`)
         }
     }
 

client/src/pages/System.jsx

@@ -54,8 +54,6 @@ const System = () => {
             case  "organizationPendingApproval": {
                 return <Organizations pendingApproval={true} tab={currentTab}/>
             }
-            default:
-                throw new Error(`Unknown tab; ${currentTab}`)
         }
     }
 

client/src/utils/MenuItems.js

@@ -27,7 +27,7 @@ export const mainMenuItems = {
 
 const doMenuItemsForUser = (user, currentOrganization) => {
     //Every user has access to the home, catalogue and help menu items
-    const newMenuItems = [mainMenuItems.home, mainMenuItems.catalogue, mainMenuItems.serviceDesk, mainMenuItems.feedback];
+    const newMenuItems = [mainMenuItems.home, mainMenuItems.catalogue, mainMenuItems.serviceDesk];
     const noOrganizationMemberships = isEmpty(user.organizationMemberships);
     if (noOrganizationMemberships) {
         return newMenuItems;