Skip to content

Commit d178a6c

Browse files
committed
Do not allow for application memberships for ADMIN invites
1 parent 955ef21 commit d178a6c

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

client/src/pages/InvitationForm.jsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ export const InvitationForm = () => {
5050
useAppStore.setState({
5151
breadcrumbPaths: [
5252
{path: "/home", value: I18n.t("breadCrumb.access"), menuItemName: mainMenuItems.home},
53-
{path: `/users/${organizationId}/team`, value: I18n.t("navigation.users"), menuItemName: mainMenuItems.users},
53+
{
54+
path: `/users/${organizationId}/team`,
55+
value: I18n.t("navigation.users"),
56+
menuItemName: mainMenuItems.users
57+
},
5458
{value: I18n.t("breadCrumb.invitations")}
5559
]
5660
});
@@ -98,7 +102,8 @@ export const InvitationForm = () => {
98102
const authorityChanged = option => {
99103
setInvitation({
100104
...invitation,
101-
intendedAuthority: option.value
105+
intendedAuthority: option.value,
106+
applicationIdentifiers: option.value === authorities.ADMIN ? [] : invitation.applicationIdentifiers
102107
});
103108
}
104109

@@ -146,7 +151,7 @@ export const InvitationForm = () => {
146151
className={"small"}
147152
/>}
148153

149-
{organization.applications.length > 0 &&
154+
{(organization.applications.length > 0 && invitation.intendedAuthority !== authorities.ADMIN) &&
150155
<SelectField
151156
value={organization.applications
152157
.filter(app => invitation.applicationIdentifiers.includes(app.id))

client/src/pages/Policies.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const Policies = () => {
3838
&& !isEmpty(currentOrganization.manageIdentifier));
3939
}, [user, currentOrganization]);
4040

41-
const toPolicyDetail = (policyIdentifier, allPolicies = policies, policyType = policyTypes.reg) => {
41+
const toPolicyDetail = (policyIdentifier, allPolicies = policies, policyType = null) => {
4242
setShowPolicyOverview(false);
4343
let newCurrentPolicy;
4444
if (policyIdentifier === "new") {

client/src/utils/MenuItems.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ const doMenuItemsForUser = (user, currentOrganization, feedbackWidgetEnabled = u
6060
if (!user.externalUser) {
6161
newMenuItems.push(mainMenuItems.accessibleApps, mainMenuItems.idp, mainMenuItems.invite, mainMenuItems.sram);
6262
}
63-
// if ((isAdmin || user.superUser) && !isEmpty(currentOrganization.manageIdentifier)) {
64-
// newMenuItems.push(mainMenuItems.policies);
65-
// }
63+
if ((isAdmin || user.superUser) && !isEmpty(currentOrganization.manageIdentifier)) {
64+
newMenuItems.push(mainMenuItems.policies);
65+
}
6666
return newMenuItems;
6767
}
6868

0 commit comments

Comments
 (0)