Skip to content

Commit ee7d7c3

Browse files
committed
Fixes #584
Fix for revisionnote only change requests
1 parent 4ca4739 commit ee7d7c3

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

server/src/main/java/access/manage/ConnectionProviderConverter.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public List<ChangeRequest> deduceChangeRequests(Connection connection,
190190
List<ChangeRequest> changeRequests = new ArrayList<>();
191191
Map<String, Object> pathUpdates = new LinkedHashMap<>();
192192
diffChangeRequestRecursive("", currentData, newData, pathUpdates);
193-
if (!pathUpdates.isEmpty()) {
193+
if (pathUpdatesWarrantChangeRequest(pathUpdates)) {
194194
ChangeRequest changeRequest = new ChangeRequest(
195195
connection.getManageIdentifier(),
196196
connection.getProtocol(),
@@ -205,6 +205,16 @@ public List<ChangeRequest> deduceChangeRequests(Connection connection,
205205
return changeRequests;
206206
}
207207

208+
private boolean pathUpdatesWarrantChangeRequest(Map<String, Object> pathUpdates) {
209+
if (pathUpdates.isEmpty()) {
210+
return false;
211+
}
212+
if (pathUpdates.size() == 1 && pathUpdates.containsKey("revisionnote")) {
213+
return false;
214+
}
215+
return true;
216+
}
217+
208218
public HashMap<String, Object> convertProviderToApplicationMetaData(Map<String, Object> provider) {
209219
Map<String, Object> metaDataFields = getMetaDataFields(getData(provider));
210220
HashMap<String, Object> updatedMetaData = new HashMap<>();

0 commit comments

Comments
 (0)