Fix/remove container from inventory (#486)

* get mongo servers from variables not inventory entries

Author: crosmuller

roles/manage/templates/application.yml.j2

@@ -79,7 +79,7 @@ spring:
     port: 25
   data:
     mongodb:
-      uri: mongodb://{{ manage.mongo_user }}:{{ manage.mongo_password }}@{% for host in groups['mongo_servers'] %}{{ hostvars[host]['inventory_hostname'] }}:{{ manage.mongo_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ manage.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}
+      uri: mongodb://{{ manage.mongo_user }}:{{ manage.mongo_password }}@{% for mongo_server in manage.mongo_servers %}{{ mongo_server }}:{{ manage.mongo_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ manage.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}
   main:
     banner-mode: "off"
 

roles/manage_provision_entities/tasks/main.yml

@@ -34,6 +34,7 @@
     body:
       entityid: "{{ manage_provision_client_id }}"
   run_once: true
+  check_mode: false # This can safely run in check mode because it is not changing anything
   register: manage_test_entity
   until: manage_test_entity is succeeded
   retries: 15

roles/mongo/defaults/main.yml

@@ -1,13 +1,19 @@
 # The global variable file mongodb installation
 
+# In the current mongo role only one cluster per environments
+# is possible, that works for now.
+mongo_servers: [] # Set this in group_vars
+#  - mongo1.example.com
+#  - mongo2.example.com
+
 # The port for mongo server
 mongod_port: 27017
 
 # The password for admin user
-mongo_admin_pass: "{{ mongo_admin_password }}"
+mongo_admin_pass: "{{ mongo_admin_password }}" # Set this in secrets
 
 # The name of the replication set
-replica_set_name: "{{ instance_name }}"
+replica_set_name: "{{ instance_name }}" # Set this in group_vars
 
 # Add a database
 mongo:

roles/mongo/tasks/postinstall.yml

@@ -34,6 +34,10 @@
     owner: root
   when: mongo_replication_role != 'arbiter'
 
+# TODO: this template gets mongo_servers from
+# the inventory, maybe change that to group vars
+# this is not on an per app basis. These are mongoservers
+# in the same cluster.
 - name: Create mongosh config file
   ansible.builtin.template:
     src: mongoshrc.js.j2

roles/mongo/templates/mongoshrc.js.j2

@@ -1,2 +1,2 @@
-db = connect("mongodb://admin:{{ mongo_admin_password }}@{% for host in groups['mongo_servers'] %}{{ hostvars[host]['inventory_hostname'] }}:{{ mongod_port }}{% if not loop.last %},{% endif %}{% endfor %}?ssl=true&tlsCAFile=/etc/pki/mongo/mongoca.pem")
+db = connect("mongodb://admin:{{ mongo_admin_password }}@{% for mongo_server in mongo_servers %}{{ mongo_server }}:{{ mongod_port }}{% if not loop.last %},{% endif %}{% endfor %}?ssl=true&tlsCAFile=/etc/pki/mongo/mongoca.pem")
 

roles/myconext/templates/application.yml.j2

@@ -234,7 +234,7 @@ verify:
 spring:
   data:
     mongodb:
-      uri: mongodb://{{ myconext.mongo_user }}:{{ myconext.mongo_password }}@{% for host in groups['mongo_servers'] %}{{ hostvars[host]['inventory_hostname'] }}:{{ myconext.mongo_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ myconext.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}
+      uri: mongodb://{{ myconext.mongo_user }}:{{ myconext.mongo_password }}@{% for mongo_server in myconext.mongo_servers %}{{ mongo_server }}:{{ myconext.mongo_port }}{% if not loop.last %},{% endif %}{% endfor %}/{{ myconext.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}
 
   mail:
     host: {{ smtp_server }}

roles/oidcng/templates/application.yml.j2

@@ -76,7 +76,7 @@ idp:
 spring:
   data:
     mongodb:
-      uri: "mongodb://{{ oidcng.mongo_user }}:{{ oidcng.mongo_password }}@{% for host in groups['mongo_servers'] %}{{ hostvars[host]['inventory_hostname'] }}:{{ oidcng.mongo_port }}{% if not loop.last %},{% endif %}{%endfor %}/{{ oidcng.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}"
+      uri: "mongodb://{{ oidcng.mongo_user }}:{{ oidcng.mongo_password }}@{% for mongo_server in oidcng.mongo_servers %}{{ mongo_server }}:{{ oidcng.mongo_port }}{% if not loop.last %},{% endif %}{%endfor %}/{{ oidcng.mongo_database }}?ssl={{ mongodb_ssl | default('true') }}"
 
   thymeleaf:
     cache: true