Use group_var's for myconext email from addresses (#600)

Author: phavekes

environments/template/group_vars/template.yml

@@ -44,9 +44,7 @@ profile_version: "3.1.4"
 teams_gui_version: "9.1.3"
 teams_server_version: "9.1.3"
 voot_version: "6.2.0"
-myconext_server_version: "6.0.2"
-myconext_gui_version: "6.0.2"
-account_gui_version: "6.0.2"
+myconext_version: "8.1.12-1"
 dashboard_server_version: "12.3.4"
 dashboard_gui_version: "12.3.4"
 invite_server_version: "0.0.2-SNAPSHOT"
@@ -306,6 +304,12 @@ myconext:
     - { name: "terms_of_service" , url: "https://example.org/x/LozaAQ"}
     - { name: "voorwaarden" , url: "https://example.org/x/HYzaAQ"}
   geo_location_  external_url: "https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-City&license_key={license_key}&suffix=tar.gz"
+  email:
+    from_deprovisioning: MyConext <noreply+deprovisioning@{{ myconext_base_domain }}>
+    from_code: MyConext <noreply@{{ myconext_base_domain }}>
+    from_app_nudge: MyConext <noreply+appnudge@{{ myconext_base_domain }}>
+    from_new_device: MyConext <noreply+newdevice@{{ myconext_base_domain }}>
+
 
 monitoring_tests:
   metadata_sp_url: "{{ monitoring_tests_metadata_sp_url }}"

roles/myconext/templates/application.yml.j2

@@ -37,10 +37,10 @@ springdoc:
     enabled: true
 
 email:
-  from_deprovisioning: <noreply+deprovisioning@{{ myconext_base_domain }}>
-  from_code: eduID <noreply@{{ myconext_base_domain }}>
-  from_app_nudge: <noreply+appnudge@{{ myconext_base_domain }}>
-  from_new_device: <noreply+newdevice@{{ myconext_base_domain }}>
+  from_deprovisioning: "{{ myconext.email.from_deprovisioning }}"
+  from_code: "{{ myconext.email.from_code }}"
+  from_app_nudge: "{{ myconext.email.from_deprovisioning }}"
+  from_new_device: "{{ myconext.email.from_deprovisioning }}"
   error: {{ error_mail_to }}
   magic-link-url: https://login.{{ myconext_base_domain }}/saml/guest-idp/magic
   my-surfconext-url: https://mijn.{{ myconext_base_domain }}