Feature/cleanup old vm stuff#501
Merged
Merged
Conversation
quartje
commented
May 27, 2025
quartje
commented
Contributor
- leftover apache files
- leftover loadbalancing port configs
- middleware vm deployment
pmeulen
approved these changes
Jun 12, 2025
Member
There was a problem hiding this comment.
I think the when clause on import_tasks: docker.yml can be removed now as well.
Those when clauses were added to make the vm.yml / docker.yml switching work with the push_* tags.
Contributor
Author
There was a problem hiding this comment.
We decided to pick this up in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.