engine - compatible with symfony 4 upgrade

Author: Stephan-Kok

core/.env.ci.dist

@@ -1,2 +1,3 @@
 APP_ENV=ci
-SYMFONY_ENV=ci
+APP_DEBUG=true
+APP_SECRET=secret

core/README.md

@@ -84,3 +84,18 @@ To mount the code in multiple containers:
 `start-dev-env.sh profile:../../OpenConext-profile userlifecycle:../../OpenConext-user-lifecycle`
 You can add as many services+local code paths that you need.
 The recommended way is to use absolute paths and the script requires the name of the service and local code path to be separated by a `:`, for each service.
+
+# Tips
+
+To start engine in local development environment use from this directory;
+
+Ensure a file `.env` exists with:
+```shell
+APP_ENV=dev
+APP_DEBUG=true
+APP_SECRET=secret
+```
+```shell
+./start-dev-env.sh engine:../../OpenConext-engineblock/
+```
+To change the running env, just edit `APP_ENV=ci` for example and re-run `./start-dev-env.sh engine:../../OpenConext-engineblock/`. You do not have to recreate all services, only to reload engineblock.

core/docker-compose.yml

@@ -107,7 +107,8 @@ services:
         condition: service_healthy
     environment:
       - APP_ENV=${APP_ENV:-prod}
-      - SYMFONY_ENV=${APP_ENV:-prod}
+      - APP_DEBUG=${APP_ENV:-false}
+      - APP_SECRET=${APP_SECRET:?APP_SECRET is not set}
 
   profile:
     image: ghcr.io/openconext/openconext-profile/profile:prod

core/engine/appconf.conf

@@ -14,8 +14,6 @@ SetEnvIf Authorization "(.*)" HTTP_AUTHORIZATION=$1
 Header always set X-Content-Type-Options "nosniff"
 
 SetEnv HTTPS on
-#SetEnv ENGINEBLOCK_ENV dev
-#SetEnv SYMFONY_ENV dev
 
 RewriteEngine On
 # We support only GET/POST

core/engine/docker-compose.override.yml

@@ -10,8 +10,8 @@ services:
       - ./engine/appconf.conf:/etc/apache2/sites-enabled/appconf.conf
     environment:
       - APP_ENV=${APP_ENV:-dev}
-      - SYMFONY_ENV=${APP_ENV:-dev}
-      - APP_DEBUG=1
+      - APP_DEBUG=${APP_DEBUG:-true}
+      - APP_SECRET=${APP_SECRET:-secret}
     healthcheck:
       test: ["CMD", "true"]
       interval: 10s