Cleanup unused showRequestAccessContainer

Author: johanib

src/OpenConext/EngineBlockBundle/Service/WayfRenderer.php

@@ -74,7 +74,6 @@ public function render(
             showRequestAccess: $showRequestAccess,
             requestId: $requestId,
             serviceProvider: $serviceProvider,
-            showRequestAccessContainer: true,
         );
 
         return $this->twig->render('@theme/Authentication/View/Proxy/wayf.html.twig', $viewModel->toArray());

src/OpenConext/EngineBlockBundle/Service/WayfViewModelFactory.php

@@ -49,7 +49,6 @@ public function create(
         bool $showRequestAccess,
         string $requestId,
         ServiceProvider $serviceProvider,
-        bool $showRequestAccessContainer,
     ): WayfViewModel {
         return new WayfViewModel(
             action: $action,
@@ -60,7 +59,6 @@ public function create(
             showIdPBanner: $showIdPBanner,
             rememberChoiceFeature: $rememberChoiceFeature,
             showRequestAccess: $showRequestAccess,
-            showRequestAccessContainer: $showRequestAccessContainer,
             requestId: $requestId,
             serviceProvider: $serviceProvider,
             connectedIdps: $this->wayfExtension->getConnectedIdps($idpList),

src/OpenConext/EngineBlockBundle/ViewModel/WayfViewModel.php

@@ -38,7 +38,6 @@ public function __construct(
         public bool $showIdPBanner,
         public bool $rememberChoiceFeature,
         public bool $showRequestAccess,
-        public bool $showRequestAccessContainer,
         public string $requestId,
         public ServiceProvider $serviceProvider,
         public ConnectedIdps $connectedIdps,

tests/unit/OpenConext/EngineBlockBundle/Service/WayfRendererTest.php

@@ -65,7 +65,6 @@ private function buildViewModel(bool $showIdPBanner = false, bool $showPreferred
             showIdPBanner: $showIdPBanner,
             rememberChoiceFeature: false,
             showRequestAccess: false,
-            showRequestAccessContainer: true,
             requestId: 'req-1',
             serviceProvider: $sp,
             connectedIdps: $emptyIdps,
@@ -181,7 +180,7 @@ public function testBannerShownWhenDefaultIdpIsInPreferredConfigButDroppedBySpit
         $this->assertTrue($capturedShowIdPBanner, 'Banner should show: default IdP was in preferred config but dropped by splitter, so it is not visible anywhere');
     }
 
-    
+
     public function testSplitsIdpListBeforePassingToFactory(): void
     {
         $preferredId = 'https://preferred.example.org';

theme/openconext/templates/layouts/scripts/default.html.twig

@@ -111,9 +111,7 @@
 </div>
 {% endif %}
 
-{% if showRequestAccessContainer is defined %}
-    <div id="request-access-scroller"><div id="request-access-container"><div id="request-access"></div></div></div>
-{% endif %}
+<div id="request-access-scroller"><div id="request-access-container"><div id="request-access"></div></div></div>
 
 <script src="/javascripts/application.min.js?v={{ assetsVersion }}" type="text/javascript"></script>