Use Symfony DI for Consent factory instead of relying on old corto serviceprovider

Author: johanib

config/services/compat.yml

@@ -50,6 +50,7 @@ services:
         class: EngineBlock_Corto_Model_Consent_Factory
         arguments:
             - "@engineblock.service.consent.ConsentHashService"
+            - "@OpenConext\\EngineBlockBundle\\Configuration\\FeatureConfiguration"
 
     engineblock.compat.saml2_id_generator:
         public: true

library/EngineBlock/Corto/Model/Consent/Factory.php

@@ -17,6 +17,7 @@
  */
 
 use OpenConext\EngineBlock\Service\Consent\ConsentHashServiceInterface;
+use OpenConext\EngineBlockBundle\Configuration\FeatureConfigurationInterface;
 
 /**
  * @todo write a test
@@ -25,11 +26,14 @@ class EngineBlock_Corto_Model_Consent_Factory
 {
 
     private ConsentHashServiceInterface $hashService;
+    private FeatureConfigurationInterface $featureConfiguration;
 
     public function __construct(
-        ConsentHashServiceInterface $hashService
+        ConsentHashServiceInterface $hashService,
+        FeatureConfigurationInterface $featureConfiguration
     ) {
         $this->hashService = $hashService;
+        $this->featureConfiguration = $featureConfiguration;
     }
 
     /**
@@ -42,12 +46,8 @@ public function create(
     ): EngineBlock_Corto_Model_Consent {
         // If attribute manipulation was executed before consent, the NameId must be retrieved from the original response
         // object, in order to ensure correct 'hashed_user_id' generation.
-        $featureConfiguration = EngineBlock_ApplicationSingleton::getInstance()
-            ->getDiContainer()
-            ->getFeatureConfiguration();
-
-        $amPriorToConsent = $featureConfiguration->isEnabled('eb.run_all_manipulations_prior_to_consent');
-        $consentEnabled = $featureConfiguration->isEnabled('eb.feature_enable_consent');
+        $amPriorToConsent = $this->featureConfiguration->isEnabled('eb.run_all_manipulations_prior_to_consent');
+        $consentEnabled = $this->featureConfiguration->isEnabled('eb.feature_enable_consent');
 
         return new EngineBlock_Corto_Model_Consent(
             $proxyServer->getConfig('ConsentStoreValues', true),