Add yaml and Symfony service container linting

Prior to this change, issues in the symfony ci container yaml were not picked up by qa, resulting in runtime errors.

Author: johanib

.github/workflows/test-integration.yml

@@ -82,6 +82,10 @@ jobs:
                 if: always()
                 run: |
                     cd docker && docker compose exec -T --user www-data engine.dev.openconext.local bash -c '
+                        echo -e "\nContainer lint\n"  && \
+                        bin/console lint:container --env=ci && \
+                        echo -e "\nYAML lint\n"  && \
+                        bin/console lint:yaml config/ && \
                         echo -e "\nTwig lint\n"  && \
                         bin/console lint:twig theme/ && \
                         cd theme && \

ci/qa/lint.sh

@@ -3,6 +3,12 @@ set -e
 
 cd $(dirname $0)/../../
 
+echo -e "\nContainer lint\n"
+bin/console lint:container --env=ci
+
+echo -e "\nYAML lint\n"
+bin/console lint:yaml config/
+
 echo -e "\nTwig lint\n"
 bin/console lint:twig theme/
 

config/services/ci/controllers.yml

@@ -24,9 +24,7 @@ services:
     engineblock.functional_test.controller.feedback:
         class: OpenConext\EngineBlockFunctionalTestingBundle\Controllers\FeedbackController
         arguments:
-            - '@translator'
             - '@twig'
-            - '@engineblock.compat.logger'
             - '@OpenConext\EngineBlock\Service\FeedbackStateHelper'
 
     engineblock.functional_test.controller.consent:

src/OpenConext/EngineBlockFunctionalTestingBundle/Features/FeedbackFooters.feature

@@ -44,6 +44,11 @@ Feature:
       And I should see "support@openconext.org"
 
 
+
+  Scenario: The functional-testing feedback page renders correctly with feedback-info
+    When I go to Engineblock URL "/functional-testing/feedback?template=session-lost&feedback-info=%7B%22requestId%22%3A%22test-abc%22%2C%22ipAddress%22%3A%221.2.3.4%22%2C%22artCode%22%3A%2231914%22%7D"
+    Then I should see "your session was lost"
+
   Scenario: When a IdP specific error page is shown and a translation is not configured the support emailaddress of the IdP should be hidden
     Given The clock on the IdP "Dummy Idp" is ahead
     And I have configured the following translations: