Skip to content

Add key rollover test #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanib merged 1 commit into from
May 5, 2026
Merged

Add key rollover test #1991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions library/EngineBlock/Application/FunctionalTestDiContainer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ public function getEncryptionKeysConfiguration()
'publicFile' => '/config/engine/engineblock.crt',
'privateFile' => $basePath . '/ci/qa-config/files/engineblock.pem',
],
'rollover' => [
'publicFile' => $basePath . '/src/OpenConext/EngineBlockFunctionalTestingBundle/Resources/keys/rolled-over.crt',
'privateFile' => $basePath . '/src/OpenConext/EngineBlockFunctionalTestingBundle/Resources/keys/rolled-over.key',
],
];
}
}
15 changes: 15 additions & 0 deletions src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Context/EngineBlockContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
* @SuppressWarnings(PHPMD.CouplingBetweenObjects) Due to all integration specific features
* @SuppressWarnings(PHPMD.ExcessivePublicCount) Both set up and tasks can be a lot...
* @SuppressWarnings(PHPMD.TooManyFields) Both set up and tasks can be a lot...
* @SuppressWarnings(PHPMD.ExcessiveClassLength) Both set up and tasks can be a lot...
*/
class EngineBlockContext extends AbstractSubContext
{
Expand Down Expand Up @@ -323,6 +324,20 @@ public function anIdpInitiatedSingleSignOnForSpIsTriggeredByIdPWithInvalidSignin
);
}

/**
* @Given /^An IdP initiated Single Sign on for SP "([^"]*)" is triggered by IdP "([^"]*)" and specifies the "([^"]*)" signing key$/
*/
public function anIdpInitiatedSingleSignOnForSpIsTriggeredByIdPWithNamedSigningKey($spName, $idpName, $keyId)
{
$mockSp = $this->mockSpRegistry->get($spName);
$mockIdP = $this->mockIdpRegistry->get($idpName);

$mink = $this->getMinkContext();
$mink->visit(
$this->engineBlock->unsolicitedLocation($mockIdP->entityId(), $mockSp->entityId(), $keyId)
);
}

/**
* @Given /^An IdP initiated Single Sign on for SP "([^"]*)" is incorrectly triggered by IdP "([^"]*)"$/
*/
Expand Down
4 changes: 4 additions & 0 deletions src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Context/MinkContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ public function theResponseShouldMatchXpath($xpath)
$xpathObj->registerNamespace('md', 'urn:oasis:names:tc:SAML:2.0:metadata');
$xpathObj->registerNamespace('mdui', Common::NS);
$xpathObj->registerNamespace('shibmd', Scope::NS);
$xpathObj->registerNamespace('samlp', 'urn:oasis:names:tc:SAML:2.0:protocol');
$xpathObj->registerNamespace('saml', 'urn:oasis:names:tc:SAML:2.0:assertion');
$nodeList = $xpathObj->query($xpath);

if (!$nodeList || $nodeList->length === 0) {
Expand Down Expand Up @@ -205,6 +207,8 @@ public function theResponseShouldNotMatchXpath($xpath)
$xpathObj->registerNamespace('ds', XMLSecurityDSig::XMLDSIGNS);
$xpathObj->registerNamespace('md', 'urn:oasis:names:tc:SAML:2.0:metadata');
$xpathObj->registerNamespace('mdui', Common::NS);
$xpathObj->registerNamespace('samlp', 'urn:oasis:names:tc:SAML:2.0:protocol');
$xpathObj->registerNamespace('saml', 'urn:oasis:names:tc:SAML:2.0:assertion');
$nodeList = $xpathObj->query($xpath);

if ($nodeList && $nodeList->length > 0) {
Expand Down
11 changes: 11 additions & 0 deletions src/OpenConext/EngineBlockFunctionalTestingBundle/Features/UnsolicitedSingleSignOn.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ Feature:
And I give my consent
And I pass through EngineBlock
Then the url should match "functional-testing/Dummy%20SP/acs"
And the response should match xpath '//ds:X509Certificate[starts-with(.,"MIIDuDCCAqCgAwIBAgIJAPdqJ9JQKN6vMA0GCSqGSIb3DQEBBQUAMEYxDzANBgNVBAMT")]'

Scenario: An IdP initiates a login with the rollover signing key
When An IdP initiated Single Sign on for SP "Dummy SP" is triggered by IdP "Dummy IdP" and specifies the "rollover" signing key
And I pass through EngineBlock
And I pass through the IdP
And I give my consent
And I pass through EngineBlock
Then the url should match "functional-testing/Dummy%20SP/acs"
# See src/OpenConext/EngineBlockFunctionalTestingBundle/Resources/keys/rolled-over.crt
And the response should match xpath '//ds:X509Certificate[starts-with(.,"MIIDhTCCAm2gAwIBAgIJALJlbT5u9cXzMA0GCSqG")]'

# Should result in a generic 500 error, the logs specify the problem in greater detail.
Scenario: An IdP initiates a login with an SP identity id query parameter
Expand Down