Skip to content

Commit 7dfca8f

Browse files
Uses slot routes instead of component prop for Svelte 5 compatibility (solving console errors) (#1241)
1 parent f461d0f commit 7dfca8f

2 files changed

Lines changed: 24 additions & 22 deletions

File tree

account-gui/src/App.svelte

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -175,17 +175,17 @@
175175
<Route path="/usecode/:id" let:params>
176176
<UseCode id="{params.id}"/>
177177
</Route>
178-
<Route path="/app-required" component={AppRequired}/>
179-
<Route path="/getapp" component={GetApp}/>
180-
<Route path="/install-app" component={InstallApp}/>
181-
<Route path="/enrollapp" component={EnrollApp}/>
182-
<Route path="/recovery" component={Recovery}/>
183-
<Route path="/recovery-code" component={RecoveryCode}/>
184-
<Route path="/phone-verification" component={PhoneVerification}/>
185-
<Route path="/phone-confirmation" component={PhoneConfirmation}/>
186-
<Route path="/congrats" component={Congrats}/>
187-
<Route path="/remember" component={RememberMe}/>
188-
<Route path="/rate-limited" component={RateLimited}/>
178+
<Route path="/app-required"><AppRequired/></Route>
179+
<Route path="/getapp"><GetApp/></Route>
180+
<Route path="/install-app"><InstallApp/></Route>
181+
<Route path="/enrollapp"><EnrollApp/></Route>
182+
<Route path="/recovery"><Recovery/></Route>
183+
<Route path="/recovery-code"><RecoveryCode/></Route>
184+
<Route path="/phone-verification"><PhoneVerification/></Route>
185+
<Route path="/phone-confirmation"><PhoneConfirmation/></Route>
186+
<Route path="/congrats"><Congrats/></Route>
187+
<Route path="/remember"><RememberMe/></Route>
188+
<Route path="/rate-limited"><RateLimited/></Route>
189189
<Route path="/usepassword/:id" let:params>
190190
<UsePassword id="{params.id}"/>
191191
</Route>
@@ -213,19 +213,21 @@
213213
<Route path="/subject-already-linked/:id" let:params>
214214
<SubjectAlreadyLinked id="{params.id}"/>
215215
</Route>
216-
<Route path="/external-account-linked-error" component={ExternalAccountLinkedError}/>
217-
<Route path="/confirm" component={Confirm}/>
218-
<Route path="/confirm-stepup" component={ConfirmStepup}/>
219-
<Route path="/confirm-external-stepup" component={ConfirmExternalStepup}/>
220-
<Route path="/success" component={Success}/>
221-
<Route path="/expired" component={LinkExpired}/>
222-
<Route path="/max-attempts" component={MaxAttempts}/>
223-
<Route path="/webauthn" component={WebAuthn}/>
216+
<Route path="/external-account-linked-error"><ExternalAccountLinkedError/></Route>
217+
<Route path="/confirm"><Confirm/></Route>
218+
<Route path="/confirm-stepup"><ConfirmStepup/></Route>
219+
<Route path="/confirm-external-stepup"><ConfirmExternalStepup/></Route>
220+
<Route path="/success"><Success/></Route>
221+
<Route path="/expired"><LinkExpired/></Route>
222+
<Route path="/max-attempts"><MaxAttempts/></Route>
223+
<Route path="/webauthn"><WebAuthn/></Route>
224224
<Route path="/webauthnTest/:id" let:params>
225225
<WebAuthnTest id="{params.id}"/>
226226
</Route>
227-
<Route path="/client/mobile/*action" component={RedirectMobileApp}/>
228-
<Route component={NotFound}/>
227+
<Route path="/client/mobile/*action" let:params>
228+
<RedirectMobileApp action="{params.action}"/>
229+
</Route>
230+
<Route><NotFound/></Route>
229231
</Router>
230232
</div>
231233
<Router url="{url}">

account-gui/src/routes/AppRequired.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import {proceed} from "../utils/sso";
1414
1515
let hash;
16-
let serviceName = null;
16+
let serviceName = "";
1717
let showSpinner = true;
1818
let showModal = false;
1919

0 commit comments

Comments
 (0)