From 1a5d7b7d411da1f0a772e10a6562fe23f11c31c8 Mon Sep 17 00:00:00 2001 From: Peter Havekes Date: Mon, 15 Jun 2026 16:36:32 +0200 Subject: [PATCH] Improve errors when an incorrect phone code was enterd --- .../main/java/myconext/exceptions/ForbiddenException.java | 5 +++++ .../src/main/java/myconext/tiqr/TiqrController.java | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/myconext-server/src/main/java/myconext/exceptions/ForbiddenException.java b/myconext-server/src/main/java/myconext/exceptions/ForbiddenException.java index 96294d67b..0346e3e8e 100644 --- a/myconext-server/src/main/java/myconext/exceptions/ForbiddenException.java +++ b/myconext-server/src/main/java/myconext/exceptions/ForbiddenException.java @@ -9,4 +9,9 @@ public class ForbiddenException extends AbstractBaseException { public ForbiddenException(String message) { super(message); } + + @Override + protected boolean suppressStackTrace() { + return true; + } } diff --git a/myconext-server/src/main/java/myconext/tiqr/TiqrController.java b/myconext-server/src/main/java/myconext/tiqr/TiqrController.java index 8767b21c7..d7aa6de33 100644 --- a/myconext-server/src/main/java/myconext/tiqr/TiqrController.java +++ b/myconext-server/src/main/java/myconext/tiqr/TiqrController.java @@ -275,7 +275,7 @@ public ResponseEntity resendPhoneCodeForSp(HttpServletRequest String sessionKey = (String) request.getSession().getAttribute(SESSION_KEY); Authentication authentication = tiqrService.authenticationStatus(sessionKey); if (!authentication.getStatus().equals(AuthenticationStatus.SUCCESS)) { - throw new ForbiddenException("Forbidden phone code, wrong status: " + authentication.getStatus()); + throw new ForbiddenException("Invalid phone code status, wrong status: " + authentication.getStatus()); } User user = userFromAuthentication(secAuthentication); String phoneNumber = phoneCode.getPhoneNumber(); @@ -398,7 +398,7 @@ private ResponseEntity doVerifyPhoneCode(PhoneVerification phon } userRepository.save(user); } else { - throw new ForbiddenException("Forbidden phone code, wrong code: " + code); + throw new ForbiddenException("Wrong phone code, wrong code: " + code); } return ResponseEntity.ok(new VerifyPhoneCode(this.magicLinkUrl)); }