Skip to content

Improve logging when handling users and institutions#236

Merged
phavekes merged 5 commits intomainfrom
feature/Improve_loging
Apr 20, 2026
Merged

Improve logging when handling users and institutions#236
phavekes merged 5 commits intomainfrom
feature/Improve_loging

Conversation

@phavekes
Copy link
Copy Markdown
Member

@phavekes phavekes commented Apr 16, 2026

When adding the automatic metadata updates, the logging on invalid signatures was removed.
Added context to log messages on users and institutions

@phavekes phavekes force-pushed the feature/Improve_loging branch 2 times, most recently from 107ce86 to b6da62a Compare April 16, 2026 11:48
@phavekes phavekes force-pushed the feature/Improve_loging branch 2 times, most recently from d773919 to c5a3049 Compare April 16, 2026 11:58
@kayjoosten kayjoosten force-pushed the feature/Improve_loging branch from c660136 to 8a1a9d3 Compare April 17, 2026 08:19
The test where failing as the complexity of the function became to
big. Therefore, some logic had to be moved to a private function.
@kayjoosten kayjoosten force-pushed the feature/Improve_loging branch from 8a1a9d3 to 0029638 Compare April 17, 2026 08:26
@kayjoosten kayjoosten requested a review from johanib April 17, 2026 08:31
@phavekes phavekes requested review from johanib and pmeulen and removed request for johanib April 17, 2026 08:31
Copy link
Copy Markdown
Contributor

@johanib johanib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging changes lgtm 👍

Comment thread src/Surfnet/AzureMfa/Application/Service/AzureMfaService.php
Comment thread src/Surfnet/AzureMfa/Application/Service/AzureMfaService.php Outdated
Comment thread src/Surfnet/AzureMfa/Application/Service/AzureMfaService.php Outdated
Comment thread src/Surfnet/AzureMfa/Application/Service/AzureMfaService.php Outdated
Comment thread .gitignore
phavekes and others added 3 commits April 20, 2026 10:17
Co-authored-by: Johan Kromhout <60608181+johanib@users.noreply.github.com>
Co-authored-by: Johan Kromhout <60608181+johanib@users.noreply.github.com>
Co-authored-by: Johan Kromhout <60608181+johanib@users.noreply.github.com>
@phavekes phavekes merged commit f9d4bdc into main Apr 20, 2026
2 checks passed
@phavekes phavekes deleted the feature/Improve_loging branch April 20, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants