Fix deprecation: Don't rely on db specific varchar size

Relying on the default column size for varchar fields is deprecated.

This change configures all varchar custom types to rely on the previous default value of 255, if not overridden.

See \Doctrine\DBAL\Platforms\AbstractPlatform::getVarcharDefaultLength

See doctrine/dbal#3263

Author: johanib

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/CommonNameType.php

@@ -34,6 +34,10 @@ class CommonNameType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/ConfigurationInstitutionType.php

@@ -33,6 +33,10 @@ class ConfigurationInstitutionType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/DocumentNumberType.php

@@ -35,6 +35,10 @@ class DocumentNumberType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/EmailType.php

@@ -33,6 +33,10 @@ class EmailType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/InstitutionRoleType.php

@@ -33,6 +33,10 @@ class InstitutionRoleType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/InstitutionType.php

@@ -33,6 +33,10 @@ class InstitutionType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/LocaleType.php

@@ -36,6 +36,10 @@ class LocaleType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/NameIdType.php

@@ -33,6 +33,10 @@ class NameIdType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }
 

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/RaLocationNameType.php

@@ -33,7 +33,10 @@ class RaLocationNameType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
-        return $platform->getStringTypeDeclarationSQL([]);
+        $clearColumn = [];
+        $clearColumn['length'] = 255;
+
+        return $platform->getStringTypeDeclarationSQL($clearColumn);
     }
 
     public function convertToDatabaseValue($value, AbstractPlatform $platform): mixed

src/Surfnet/StepupMiddleware/ApiBundle/Doctrine/Type/SecondFactorTypeType.php

@@ -33,6 +33,10 @@ class SecondFactorTypeType extends Type
 
     public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
     {
+        if (!isset($column['length'])) {
+            $column['length'] = 255;
+        }
+
         return $platform->getStringTypeDeclarationSQL($column);
     }