PHPStan fixes

Author: johanib

ci/qa/phpstan.neon

@@ -5,6 +5,7 @@ includes:
     - ../../vendor/phpstan/phpstan-symfony/extension.neon
 
 parameters:
+	treatPhpDocTypesAsCertain: false
 	level: 9
 	paths:
 		- ../../src

ci/qa/phpunit

@@ -7,5 +7,5 @@ cd $(dirname $0)/../../
 
 # PHPUnit Bridge should always be used in Symfony applications. (https://symfony.com/doc/current/components/phpunit_bridge.html)
 # This will create a phpunit executable in /bin/ instead of /vendor/bin/
-./vendor/bin/phpunit --configuration=ci/qa/phpunit.xml --coverage-text --stop-on-error $1
+./vendor/bin/phpunit --configuration=ci/qa/phpunit.xml --coverage-text --stop-on-error $@
 ./vendor/bin/phpunit --configuration=ci/qa/phpunit.xml --testsuite=database

composer.json

@@ -63,12 +63,12 @@
         "moontoast/math": "^1.2.1",
         "overtrue/phplint": ">=9.5.6",
         "phpmd/phpmd": "^2.15",
-        "phpstan/phpstan": "^1.11.x-dev",
-        "phpstan/phpstan-doctrine": "^1.5.7",
-        "phpstan/phpstan-mockery": "^1.1.3",
-        "phpstan/phpstan-symfony": "^1.4.13",
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-doctrine": "^2.0",
+        "phpstan/phpstan-mockery": "^2.0",
+        "phpstan/phpstan-symfony": "^2.0",
         "phpunit/phpunit": "^9.6.22",
-        "rector/rector": "^1.2",
+        "rector/rector": "^2.2",
         "sebastian/phpcpd": "^6.0.3",
         "squizlabs/php_codesniffer": "^3.11.3",
         "symfony/browser-kit": "6.4.*",
@@ -101,7 +101,7 @@
         "phpcs": "./ci/qa/phpcs",
         "phpcbf": "./ci/qa/phpcbf",
         "phpcpd": "./ci/qa/phpcpd",
-        "phpunit": "./ci/qa/phpunit --",
+        "phpunit": "./ci/qa/phpunit",
 
         "post-install-cmd": [
             "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters",

composer.lock

@@ -38,7 +38,7 @@ class NewInstitutionConfigurationCreatedEvent implements SerializableInterface
 {
 
     /**
-     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
+     * @SuppressWarnings("PHPMD.ExcessiveParameterList")
      */
     public function __construct(
         public InstitutionConfigurationId $institutionConfigurationId,

src/Surfnet/Stepup/Configuration/Event/NewInstitutionConfigurationCreatedEvent.php

@@ -70,11 +70,11 @@
  *    the aggregate but by playing the events onto the aggregate.
  * 2. If one of the configuration options should be nullable, take a look at the applyUseRaOptionChangedEvent doc block
  *
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects) Events and value objects
- * @SuppressWarnings(PHPMD.TooManyMethods) AggregateRoot
- * @SuppressWarnings(PHPMD.TooManyPublicMethods) AggregateRoot
- * @SuppressWarnings(PHPMD.ExcessiveClassComplexity) AggregateRoot
- * @SuppressWarnings(PHPMD.TooManyFields) AggregateRoot
+ * @SuppressWarnings("PHPMD.CouplingBetweenObjects") Events and value objects
+ * @SuppressWarnings("PHPMD.TooManyMethods") AggregateRoot
+ * @SuppressWarnings("PHPMD.TooManyPublicMethods") AggregateRoot
+ * @SuppressWarnings("PHPMD.ExcessiveClassComplexity") AggregateRoot
+ * @SuppressWarnings("PHPMD.TooManyFields") AggregateRoot
  */
 class InstitutionConfiguration extends EventSourcedAggregateRoot implements InstitutionConfigurationInterface
 {
@@ -669,7 +669,7 @@ protected function applyRaLocationRemovedEvent(RaLocationRemovedEvent $event): v
     }
 
     /**
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
      */
     protected function applyInstitutionConfigurationRemovedEvent(InstitutionConfigurationRemovedEvent $event): void
     {

src/Surfnet/Stepup/Configuration/InstitutionConfiguration.php

@@ -25,8 +25,8 @@
 use TypeError;
 
 /**
- * @SuppressWarnings(PHPMD.TooManyMethods)
- * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings("PHPMD.TooManyMethods")
+ * @SuppressWarnings("PHPMD.TooManyPublicMethods")
  */
 class DateTime implements Stringable
 {

src/Surfnet/Stepup/DateTime/DateTime.php

@@ -125,7 +125,7 @@ public function verifyEmail(string $verificationNonce): void;
      * Attempts to vet another identity's verified second factor.
      *
      *
-     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
+     * @SuppressWarnings("PHPMD.ExcessiveParameterList")
      */
     public function vetSecondFactor(
         Identity                          $registrant,