-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to symfony 7.4 #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
25d33b0
Plain package update
johanib e997288
PHPStan fixes
johanib 88ec4dd
phpstan update & phpstan fixes
johanib a15da7b
Allow dynamic properties on FooBarCommand
johanib 1b2cb57
Add rector & apply basic rules
johanib 788892d
Clean & enforce clean imports
johanib 0e8cef3
Fix deprecation: use getStringTypeDeclarationSQL instead of getVarcha…
johanib 74e1cf5
Upgrade to PHPUnit 10 (for attribute support) & transition from annot…
johanib 0cd1223
Also apply the phpcs rules to tests, mainly for import management rea…
johanib e2558f9
Don't recast variables that are already in the correc type.
johanib 7ca65c0
Remove deprecated setAccessible. This is no longer needed, everything…
johanib 7756b82
Rector: FunctionLikeToFirstClassCallableRector, ClosureToArrowFunctio…
johanib 29230b6
Remove doctrine/annotations
johanib 80fdf17
Fix Abstract test
johanib 91037ce
Update dev packages
johanib 2762ec9
Handle framework deprecations.
johanib a55f912
Handle twig sandbox deprecation
johanib 94cd381
Disable code coverage to prevent warnings.
johanib c9e0563
Upgrade Symfony 6.4 > 7.3
johanib 85958d9
Commands & twig functions now use attributes.
johanib e92e4dd
Require `doctrine/annotations` because `jms/translation-bundle` depen…
johanib 4505834
Prior to this change, the custom console commands would not be availa…
johanib 0afce1e
Use attributes for more complicated commands
johanib 9682ccf
Update readme & metadata
johanib 22774d0
Upgrade Symfony 7.3 > 7.4
johanib 0576ed6
Doctrine: No longer rely on the deprecated `commented` setting in the…
johanib fe35a52
Fix deprecation: Don't rely on db specific varchar size
johanib d89d2f3
Fix deprecation: Doctrine safepoints
johanib 5f1f9a0
Fix deprecation: $request->get
johanib 6bf2473
AllowDynamicProperties on RegisterSelfAssertedSecondFactorCommand and…
johanib 602587c
Add changelog
johanib 95fe6a3
rework
johanib File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| .idea | ||
| .github/*.md | ||
| /web/bundles/ | ||
| /web/app_dev.php | ||
| /web/app_test.php | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use Rector\Config\RectorConfig; | ||
| use Rector\Php74\Rector\Property\RestoreDefaultNullToNullableTypePropertyRector; | ||
| use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector; | ||
| use Rector\Php81\Rector\Property\ReadOnlyPropertyRector; | ||
| use Rector\Php82\Rector\Class_\ReadOnlyClassRector; | ||
|
|
||
| return RectorConfig::configure() | ||
| ->withPaths([ | ||
| __DIR__ . '/../../config', | ||
| __DIR__ . '/../../src', | ||
| __DIR__ . '/../../tests', | ||
| __DIR__ . '/../../templates', | ||
| ]) | ||
| ->withPhpSets() | ||
| ->withAttributesSets(all: true) | ||
| ->withComposerBased(symfony: true, twig: true, doctrine: true, phpunit: true) | ||
| ->withTypeCoverageLevel(10) | ||
| ->withDeadCodeLevel(10) | ||
| ->withCodeQualityLevel(10) | ||
| ->withSkip([ | ||
| ReadOnlyClassRector::class, | ||
| ReadOnlyPropertyRector::class, | ||
| ClassPropertyAssignToConstructorPromotionRector::class, | ||
| RestoreDefaultNullToNullableTypePropertyRector::class, | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env sh | ||
|
|
||
| # Ensure we run from project root | ||
| cd "$(dirname "$0")/../../" || exit 1 | ||
| ./vendor/bin/rector --config=ci/qa/rector.php "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MKodde marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.