Apply withPhpSets rectors

Author: johanib

ci/qa/rector.php

@@ -12,10 +12,7 @@
          __DIR__ . '/../../templates',
     ])
     // uncomment to reach your current PHP version
-//     ->withPhpSets()
+     ->withPhpSets()
     ->withAttributesSets(all: true)
     ->withComposerBased(twig: true, doctrine: true, phpunit: true, symfony: true)
-//    ->withTypeCoverageLevel(0)
-//    ->withDeadCodeLevel(0)
-//    ->withCodeQualityLevel(0)
     ;

src/Surfnet/StepupRa/RaBundle/Tests/Security/Session/SessionLifetimeGuardTest.php

@@ -238,7 +238,6 @@ public function bothLimitsVerificationProvider(): array
     private function setCurrentTime(DateTime $now = null): void
     {
         $nowProperty = new ReflectionProperty(DateTime::class, 'now');
-        $nowProperty->setAccessible(true);
         $nowProperty->setValue(null, $now);
     }
 

src/Surfnet/StepupRa/RaBundle/Tests/Security/Session/SessionStorageTest.php

@@ -342,7 +342,6 @@ public function a_session_can_be_migrated()
     private function setCurrentTime(DateTime $now = null): void
     {
         $nowProperty = new ReflectionProperty(DateTime::class, 'now');
-        $nowProperty->setAccessible(true);
         $nowProperty->setValue(null, $now);
     }
 }

src/Surfnet/StepupRa/RaBundle/Value/DateTime.php

@@ -42,7 +42,7 @@ class DateTime implements Stringable
      */
     private static ?self $now = null;
 
-    private CoreDateTime $dateTime;
+    private readonly CoreDateTime $dateTime;
 
     public static function now(): DateTime
     {