Coding standards: auto remove unused imports and require use.

Author: johanib

ci/qa/phpcbf

@@ -3,4 +3,4 @@
 cd $(dirname $0)/../../
 
 # https://github.com/squizlabs/PHP_CodeSniffer/wiki/Fixing-Errors-Automatically
-./vendor/bin/phpcbf --standard=ci/qa/phpcs.xml $1
+./vendor/bin/phpcbf --standard=ci/qa/phpcs.xml --extensions=php src $1

ci/qa/phpcs

@@ -3,4 +3,4 @@
 cd $(dirname $0)/../../
 
 # https://github.com/squizlabs/PHP_CodeSniffer/wiki/Usage
-./vendor/bin/phpcs --report=full --standard=ci/qa/phpcs.xml --ignore=*/Tests/* --warning-severity=0 --extensions=php src
+./vendor/bin/phpcs --report=full --standard=ci/qa/phpcs.xml --warning-severity=0 --extensions=php src

ci/qa/phpcs.xml

@@ -15,5 +15,13 @@
             <property name="lineLimit" value="120"/>
             <property name="absoluteLineLimit" value="150"/>
         </properties>
+      <exclude-pattern>src/Tests/*</exclude-pattern>
     </rule>
+
+  <rule ref="PSR1.Methods.CamelCapsMethodName">
+    <exclude-pattern>src/Tests/*</exclude-pattern>
+  </rule>
+
+  <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"/>
+  <rule ref="SlevomatCodingStandard.Namespaces.UnusedUses"/>
 </ruleset>

composer.json

@@ -29,6 +29,7 @@
         "phpunit/phpunit": "^11.0.0",
         "rector/rector": "^2.2",
         "sebastian/exporter": "^6.3",
+        "slevomat/coding-standard": "^8.24",
         "squizlabs/php_codesniffer": "^4.0",
         "symfony/phpunit-bridge": "^6.3"
     },
@@ -68,6 +69,7 @@
     "config": {
         "sort-packages": true,
         "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true,
             "phpstan/extension-installer": true
         }
     }

src/Http/Exception/InvalidRequestException.php

@@ -18,9 +18,8 @@
 
 namespace Surfnet\SamlBundle\Http\Exception;
 
-use Surfnet\SamlBundle\Exception\Exception;
 use Surfnet\SamlBundle\Exception\RuntimeException;
 
-class InvalidRequestException extends RuntimeException implements Exception
+class InvalidRequestException extends RuntimeException
 {
 }

src/Http/ReceivedAuthnRequestPost.php

@@ -18,7 +18,6 @@
 
 namespace Surfnet\SamlBundle\Http;
 
-use Exception;
 use RobRichards\XMLSecLibs\XMLSecurityKey;
 use Surfnet\SamlBundle\Http\Exception\InvalidRequestException;
 use Surfnet\SamlBundle\SAML2\ReceivedAuthnRequest;
@@ -81,7 +80,7 @@ public function getRelayState(): ?string
     }
 
     /**
-     * @throws Exception when signature is invalid (@see SAML2\Utils::validateSignature)
+     * @throws \Exception when signature is invalid (@see SAML2\Utils::validateSignature)
      */
     public function verify(XMLSecurityKey $key): bool
     {

src/Monolog/SamlAuthenticationLogger.php

@@ -20,6 +20,7 @@
 namespace Surfnet\SamlBundle\Monolog;
 
 use Psr\Log\LoggerInterface;
+use Stringable;
 
 /**
  * Decorates a PSR logger and adds information pertaining to a SAML request procedure to each message's context.
@@ -45,47 +46,47 @@ public function forAuthentication(string $requestId): self
         return $logger;
     }
 
-    public function emergency(string|\Stringable $message, array $context = []): void
+    public function emergency(string|Stringable $message, array $context = []): void
     {
         $this->logger->emergency($message, $this->modifyContext($context));
     }
 
-    public function alert(string|\Stringable $message, array $context = []): void
+    public function alert(string|Stringable $message, array $context = []): void
     {
         $this->logger->alert($message, $this->modifyContext($context));
     }
 
-    public function critical(string|\Stringable $message, array $context = []): void
+    public function critical(string|Stringable $message, array $context = []): void
     {
         $this->logger->critical($message, $this->modifyContext($context));
     }
 
-    public function error(string|\Stringable $message, array $context = []): void
+    public function error(string|Stringable $message, array $context = []): void
     {
         $this->logger->error($message, $this->modifyContext($context));
     }
 
-    public function warning(string|\Stringable $message, array $context = []): void
+    public function warning(string|Stringable $message, array $context = []): void
     {
         $this->logger->warning($message, $this->modifyContext($context));
     }
 
-    public function notice(string|\Stringable $message, array $context = []): void
+    public function notice(string|Stringable $message, array $context = []): void
     {
         $this->logger->notice($message, $this->modifyContext($context));
     }
 
-    public function info(string|\Stringable $message, array $context = []): void
+    public function info(string|Stringable $message, array $context = []): void
     {
         $this->logger->info($message, $this->modifyContext($context));
     }
 
-    public function debug(string|\Stringable $message, array $context = []): void
+    public function debug(string|Stringable $message, array $context = []): void
     {
         $this->logger->debug($message, $this->modifyContext($context));
     }
 
-    public function log($level, string|\Stringable $message, array $context = []): void
+    public function log($level, string|Stringable $message, array $context = []): void
     {
         $this->logger->log($level, $message, $this->modifyContext($context));
     }

src/SAML2/AuthnRequestFactory.php

@@ -18,7 +18,6 @@
 
 namespace Surfnet\SamlBundle\SAML2;
 
-use Exception;
 use RobRichards\XMLSecLibs\XMLSecurityKey;
 use SAML2\AuthnRequest as SAML2AuthnRequest;
 use SAML2\Certificate\PrivateKeyLoader;
@@ -70,7 +69,7 @@ public static function createFromHttpRequest(Request $httpRequest): AuthnRequest
     }
 
     /**
-     * @throws Exception
+     * @throws \Exception
      */
     private static function createAuthnRequestFromHttpRequest(
         Request $httpRequest

src/SAML2/Extensions/GsspUserAttributesChunk.php

@@ -19,7 +19,6 @@
 
 use DOMDocument;
 use DOMElement;
-use DOMNode;
 use SAML2\Utils;
 
 class GsspUserAttributesChunk extends Chunk

src/SAML2/ReceivedAuthnRequest.php

@@ -18,7 +18,6 @@
 
 namespace Surfnet\SamlBundle\SAML2;
 
-use Exception;
 use RobRichards\XMLSecLibs\XMLSecurityKey;
 use SAML2\AuthnRequest as SAML2AuthnRequest;
 use SAML2\Constants;
@@ -166,7 +165,7 @@ public function getScopingRequesterIds(): array
     }
 
     /**
-     * @throws Exception when signature is invalid (@see SAML2\Utils::validateSignature)
+     * @throws \Exception when signature is invalid (@see SAML2\Utils::validateSignature)
      */
     public function verify(XMLSecurityKey $key): bool
     {