Conversation
johanib
force-pushed
the
feature/maintenance_nov-25
branch
from
0b5a287 to
ffdf160
Compare
Contributor
Author
|
I think we should upgrade to simplesamlphp/saml2 5 as well. Ill take a look. |
MKodde
requested changes
Nov 10, 2025
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
Lots of changes here.. Nice work 👍
I added some questions and suggestions in code review comments. And additionally this question:
Your removed the copy paste detector. I know why :) Have you looked for a substitute? I know of a node module that can check for code duplication. But that might be a nuisance to add here.. CPD is somewhat significant but might not be the most valuable QA tool. One we might be able to live without..
MKodde
reviewed
Nov 10, 2025
johanib
force-pushed
the
feature/maintenance_nov-25
branch
from
d872a42 to
1fd5f6f
Compare
MKodde
approved these changes
Nov 17, 2025
Upgrade PHPUnit and apply attributes
Update codensniffer, phpunit, psr/log and fix issues.
Coding standards: Add AlphabeticallySortedUses
PHPCS: search comments for annotations Prior to this change, phpcs would not allow imports for classes referenced in annotations only. This change enables that. Also, fix a wrong reference to `\LogicException` where in reality `\Surfnet\SamlBundle\Security\Exception\LogicException` was thrown. Update to samlbundle exception.
johanib
force-pushed
the
feature/maintenance_nov-25
branch
from
6942b4a to
15f02a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.