fix webhook review file links

Author: CompleteDotTech

src/adapter.ts

@@ -1092,10 +1092,10 @@ async function publishResultIfConfigured(task: JsonObject, resultPath: string, t
   }
 }
 
-function publicationCommentBody(task: JsonObject, result: JsonObject): string {
+export function publicationCommentBody(task: JsonObject, result: JsonObject): string {
   const status = result.status || "unknown";
-  const summary = String(result.summary || "No summary returned.");
-  const prBody = String(result.pr_body || "");
+  const summary = linkGithubFileMentions(task, String(result.summary || "No summary returned."));
+  const prBody = linkGithubFileMentions(task, String(result.pr_body || ""));
   const filesChanged = Array.isArray(result.files_changed) ? result.files_changed : [];
   const commits = Array.isArray(result.commits) ? result.commits : [];
   const taskId = String(task.task_id || "");
@@ -1117,12 +1117,12 @@ function publicationCommentBody(task: JsonObject, result: JsonObject): string {
       `- Review context SHA-256: \`${evidence.review_context_sha256}\``,
     );
     if (changedFiles.length) {
-      parts.push(`- Files: ${changedFiles.slice(0, 20).map((file) => `\`${file}\``).join(", ")}`);
+      parts.push(`- Files: ${changedFiles.slice(0, 20).map((file) => githubFileMarkdown(task, String(file))).join(", ")}`);
     }
   } else {
     parts.push("- No PR review evidence was captured for this run.");
   }
-  parts.push(...structuredReviewLines(review));
+  parts.push(...structuredReviewLines(review, task));
   parts.push(
     "",
     `**Files changed:** ${filesChanged.length}`,
@@ -1133,6 +1133,109 @@ function publicationCommentBody(task: JsonObject, result: JsonObject): string {
   return parts.join("\n");
 }
 
+function githubBlobBase(task: JsonObject): string | null {
+  const repository = String(task.repository || "").trim();
+  if (!/^[A-Za-z0-9_.-]+\/[A-Za-z0-9_.-]+$/.test(repository)) {
+    return null;
+  }
+  const evidence = (task.review_evidence as JsonObject | undefined) || {};
+  const ref = String(evidence.head_sha || evidence.workspace_head_sha || task.default_branch || "").trim();
+  if (!ref) {
+    return null;
+  }
+  const encodedRef = encodeURIComponent(ref).replaceAll("%2F", "/");
+  return `https://github.com/${repository}/blob/${encodedRef}`;
+}
+
+function parseRepoRelativePath(rawPath: string): {display: string; path: string; line: number | null} | null {
+  const display = rawPath.trim();
+  if (!display || display !== rawPath || /[\s<>]/.test(display)) {
+    return null;
+  }
+  if (/^[\\/]/.test(display) || /^[A-Za-z]:[\\/]/.test(display)) {
+    return null;
+  }
+
+  let path = display.replaceAll("\\", "/");
+  let line: number | null = null;
+  const lineMatch = /^(.*):(\d+)$/.exec(path);
+  if (lineMatch) {
+    path = lineMatch[1];
+    line = Number(lineMatch[2]);
+  }
+  if (/^[A-Za-z][A-Za-z0-9+.-]*:/.test(path)) {
+    return null;
+  }
+  while (path.startsWith("./")) {
+    path = path.slice(2);
+  }
+  const segments = path.split("/");
+  const filename = segments.at(-1) || "";
+  if (
+    !path ||
+    path.includes("//") ||
+    segments.some((segment) => !segment || segment === "." || segment === "..") ||
+    !/\.[A-Za-z][A-Za-z0-9._-]{0,15}$/.test(filename)
+  ) {
+    return null;
+  }
+  return {display, path, line};
+}
+
+function githubFileMarkdown(task: JsonObject, rawPath: string, lineOverride: number | null = null): string {
+  const target = parseRepoRelativePath(rawPath);
+  const base = githubBlobBase(task);
+  if (!target || !base) {
+    return `\`${rawPath}\``;
+  }
+  const encodedPath = target.path.split("/").map((segment) => encodeURIComponent(segment)).join("/");
+  const line = lineOverride ?? target.line;
+  const lineAnchor = line !== null && Number.isFinite(line) && line > 0 ? `#L${line}` : "";
+  return `[\`${target.display}\`](${base}/${encodedPath}${lineAnchor})`;
+}
+
+function linkGithubFileMentions(task: JsonObject, text: string): string {
+  const fencePattern = /(```[\s\S]*?```)/g;
+  return text
+    .split(fencePattern)
+    .map((segment, index) => {
+      if (index % 2 === 1) {
+        return segment;
+      }
+      return segment.replace(/`([^`\n]+)`/g, (match, rawPath: string, offset: number) => {
+        const alreadyLinkText = segment[offset - 1] === "[" && segment.slice(offset + match.length, offset + match.length + 2) === "](";
+        if (alreadyLinkText) {
+          return match;
+        }
+        const linked = githubFileMarkdown(task, rawPath);
+        return linked === `\`${rawPath}\`` ? match : linked;
+      });
+    })
+    .join("");
+}
+
+function reviewTestCommandMarkdown(task: JsonObject, rawCommand: string): string {
+  const command = rawCommand.trim();
+  if (!command) {
+    return "`unknown command`";
+  }
+
+  let linkedAny = false;
+  const parts = command.split(/(\s+)/).map((part) => {
+    if (!part || /^\s+$/.test(part)) {
+      return part;
+    }
+    const linked = githubFileMarkdown(task, part);
+    if (linked !== `\`${part}\``) {
+      linkedAny = true;
+      return linked;
+    }
+    return `\`${part}\``;
+  });
+
+  return linkedAny ? parts.join("") : `\`${command}\``;
+}
+
 function reviewFixLoopLines(task: JsonObject): string[] {
   const loops = Array.isArray(task.review_fix_loops) ? (task.review_fix_loops as JsonObject[]) : [];
   if (!loops.length) {
@@ -1148,7 +1251,7 @@ function reviewFixLoopLines(task: JsonObject): string[] {
   return lines;
 }
 
-function structuredReviewLines(review: JsonObject): string[] {
+function structuredReviewLines(review: JsonObject, task: JsonObject): string[] {
   if (!Object.keys(review).length) {
     return ["", "### Structured review", "- No structured review result was emitted."];
   }
@@ -1162,15 +1265,15 @@ function structuredReviewLines(review: JsonObject): string[] {
   const reviewedFiles = Array.isArray(review.reviewed_files) ? review.reviewed_files : [];
   lines.push(`- Reviewed files: ${reviewedFiles.length}`);
   if (reviewedFiles.length) {
-    lines.push(`- Reviewed file list: ${reviewedFiles.slice(0, 20).map((path) => `\`${path}\``).join(", ")}`);
+    lines.push(`- Reviewed file list: ${reviewedFiles.slice(0, 20).map((path) => githubFileMarkdown(task, String(path))).join(", ")}`);
     if (reviewedFiles.length > 20) {
       lines.push("- Reviewed file list truncated after 20 entries.");
     }
   }
   const supportingFiles = Array.isArray(review.supporting_files) ? review.supporting_files : [];
   lines.push(`- Supporting files inspected: ${supportingFiles.length}`);
   if (supportingFiles.length) {
-    lines.push(`- Supporting file list: ${supportingFiles.slice(0, 20).map((path) => `\`${path}\``).join(", ")}`);
+    lines.push(`- Supporting file list: ${supportingFiles.slice(0, 20).map((path) => githubFileMarkdown(task, String(path))).join(", ")}`);
     if (supportingFiles.length > 20) {
       lines.push("- Supporting file list truncated after 20 entries.");
     }
@@ -1182,19 +1285,21 @@ function structuredReviewLines(review: JsonObject): string[] {
     if (finding.line !== undefined && finding.line !== null) {
       location = `${location}:${finding.line}`;
     }
-    lines.push(`  ${index + 1}. \`${finding.severity || "unknown"}\` ${location} - ${finding.title || "Untitled finding"}`);
+    const linkedLocation = githubFileMarkdown(task, location, Number(finding.line || 0) || null);
+    lines.push(`  ${index + 1}. \`${finding.severity || "unknown"}\` ${linkedLocation} - ${finding.title || "Untitled finding"}`);
   });
   if (findings.length > 10) {
     lines.push("- Findings truncated after 10 entries.");
   }
   if (review.no_findings_reason) {
-    lines.push(`- No-findings reason: ${review.no_findings_reason}`);
+    lines.push(`- No-findings reason: ${linkGithubFileMentions(task, String(review.no_findings_reason))}`);
   }
   const testsRun = Array.isArray(review.tests_run) ? (review.tests_run as JsonObject[]) : [];
   lines.push(`- Tests reported by runtime: ${testsRun.length}`);
   testsRun.slice(0, 10).forEach((item) => {
-    const summary = item.output_summary ? ` - ${item.output_summary}` : "";
-    lines.push(`  - \`${item.command || "unknown command"}\`: \`${item.status || "unknown"}\`${summary}`);
+    const command = reviewTestCommandMarkdown(task, String(item.command || "unknown command"));
+    const summary = item.output_summary ? ` - ${linkGithubFileMentions(task, String(item.output_summary))}` : "";
+    lines.push(`  - ${command}: \`${item.status || "unknown"}\`${summary}`);
   });
   if (testsRun.length > 10) {
     lines.push("- Test list truncated after 10 entries.");

tests/webhook-adapter.test.ts

@@ -9,6 +9,7 @@ import {
   buildTaskFromEvent,
   createConfig,
   handleRequest,
+  publicationCommentBody,
   type JsonObject,
 } from "../src/adapter.js";
 
@@ -349,6 +350,98 @@ test("example policy routes a labeled issue to the configured familiar", () => {
   });
 });
 
+test("publication body links screenshot-style file mentions to GitHub blobs", () => {
+  const body = publicationCommentBody(
+    {
+      task_id: "task-file-links",
+      repository: "OpenCoven/coven-github-webhook",
+      default_branch: "main",
+      review_evidence: {
+        head_sha: "abc123def456",
+      },
+    },
+    {
+      status: "success",
+      summary: [
+        "### Files inspected",
+        "",
+        "- `src/lib/server/skills-directory.ts`",
+        "- `README.md:12`",
+        "- `pnpm test`",
+        "",
+        "```ts",
+        "`src/not-linked-inside-fence.ts`",
+        "```",
+      ].join("\n"),
+      review: {},
+    },
+  );
+
+  assert.match(
+    body,
+    /\[`src\/lib\/server\/skills-directory\.ts`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/abc123def456\/src\/lib\/server\/skills-directory\.ts\)/,
+  );
+  assert.match(
+    body,
+    /\[`README\.md:12`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/abc123def456\/README\.md#L12\)/,
+  );
+  assert.match(body, /- `pnpm test`/);
+  assert.match(body, /`src\/not-linked-inside-fence\.ts`/);
+  assert.doesNotMatch(body, /\[`src\/not-linked-inside-fence\.ts`\]/);
+});
+
+test("publication body links structured review file lists and findings", () => {
+  const body = publicationCommentBody(
+    {
+      task_id: "task-structured-links",
+      repository: "OpenCoven/coven-github-webhook",
+      default_branch: "main",
+      review_evidence: {
+        head_sha: "feedface",
+        changed_files: ["src/app.ts"],
+        changed_file_count: 1,
+      },
+    },
+    {
+      status: "success",
+      summary: "Done.",
+      review: {
+        mode: "review",
+        evidence_status: "complete",
+        reviewed_files: ["src/app.ts"],
+        supporting_files: ["tests/app.test.ts"],
+        findings: [
+          {
+            severity: "medium",
+            file: "src/app.ts",
+            line: 7,
+            title: "Example finding",
+          },
+        ],
+        no_findings_reason: "Checked `tests/app.test.ts` with `npm test`.",
+        tests_run: [
+          {
+            command: "Read src/app.ts",
+            status: "passed",
+            output_summary: "inspected `tests/app.test.ts` coverage.",
+          },
+          {
+            command: "npm test",
+            status: "passed",
+          },
+        ],
+      },
+    },
+  );
+
+  assert.match(body, /\[`src\/app\.ts`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/feedface\/src\/app\.ts\)/);
+  assert.match(body, /\[`tests\/app\.test\.ts`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/feedface\/tests\/app\.test\.ts\)/);
+  assert.match(body, /\[`src\/app\.ts:7`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/feedface\/src\/app\.ts#L7\)/);
+  assert.match(body, /`Read` \[`src\/app\.ts`\]\(https:\/\/github\.com\/OpenCoven\/coven-github-webhook\/blob\/feedface\/src\/app\.ts\): `passed`/);
+  assert.match(body, /with `npm test`/);
+  assert.match(body, /- `npm test`: `passed`/);
+});
+
 test("demo mode handles a signed labeled issue without external GitHub calls", async () => {
   const secret = "demo-route-secret";
   const stateDir = tempStateDir();