fix issue webhook trigger gating

Author: CompleteDotTech

src/adapter.ts

@@ -404,6 +404,36 @@ function labelsIncludeTrigger(labels: JsonValue | undefined, policy: JsonObject)
   return false;
 }
 
+function issueAssignedToBot(issue: JsonObject, policy: JsonObject): boolean {
+  const wanted = new Set(((policy.bot_usernames as JsonValue[]) || []).map((username) => String(username).toLowerCase()));
+  if (wanted.size === 0) {
+    return false;
+  }
+  const assignees: JsonValue[] = [];
+  if (issue.assignee) {
+    assignees.push(issue.assignee);
+  }
+  if (Array.isArray(issue.assignees)) {
+    assignees.push(...issue.assignees);
+  }
+  for (const assignee of assignees) {
+    const login = typeof assignee === "object" && assignee !== null && !Array.isArray(assignee)
+      ? String((assignee as JsonObject).login || "")
+      : String(assignee);
+    if (wanted.has(login.toLowerCase())) {
+      return true;
+    }
+  }
+  return false;
+}
+
+function triggerEnabled(policy: JsonObject, trigger: string): boolean {
+  if (policy.enabled_triggers === undefined) {
+    return true;
+  }
+  return new Set(((policy.enabled_triggers as JsonValue[]) || []).map((value) => String(value))).has(trigger);
+}
+
 export function buildTaskFromEvent(
   eventName: string,
   deliveryId: string,
@@ -437,6 +467,12 @@ export function buildTaskFromEvent(
   if (eventName === "issue_comment") {
     const issue = (payload.issue as JsonObject | undefined) || {};
     const comment = (payload.comment as JsonObject | undefined) || {};
+    if (payload.action !== "created") {
+      return ignored(base, "unsupported_issue_comment_action");
+    }
+    if (!triggerEnabled(policy, "issue_comment.created")) {
+      return ignored(base, "issue_comment_not_enabled");
+    }
     if (!mentioned(comment.body, policy)) {
       return ignored(base, "issue_comment_without_mention");
     }
@@ -468,6 +504,12 @@ export function buildTaskFromEvent(
   if (eventName === "pull_request_review_comment") {
     const comment = (payload.comment as JsonObject | undefined) || {};
     const pullRequest = (payload.pull_request as JsonObject | undefined) || {};
+    if (payload.action !== "created") {
+      return ignored(base, "unsupported_pr_review_comment_action");
+    }
+    if (!triggerEnabled(policy, "pull_request_review_comment.created")) {
+      return ignored(base, "pr_review_comment_not_enabled");
+    }
     if (!mentioned(comment.body, policy)) {
       return ignored(base, "pr_review_comment_without_mention");
     }
@@ -492,14 +534,23 @@ export function buildTaskFromEvent(
   if (eventName === "issues") {
     const issue = (payload.issue as JsonObject | undefined) || {};
     const action = payload.action;
-    if (action !== "assigned" && action !== "labeled" && action !== "opened") {
+    if (action !== "assigned" && action !== "labeled") {
       return ignored(base, "unsupported_issue_action");
     }
+    if (action === "assigned" && !triggerEnabled(policy, "issues.assigned")) {
+      return ignored(base, "issue_assigned_not_enabled");
+    }
+    if (action === "assigned" && !issueAssignedToBot(issue, policy)) {
+      return ignored(base, "issue_assigned_to_unmanaged_user");
+    }
+    if (action === "labeled" && !triggerEnabled(policy, "issues.labeled")) {
+      return ignored(base, "issue_label_not_enabled");
+    }
     if (action === "labeled" && !labelsIncludeTrigger(issue.labels, policy)) {
       return ignored(base, "issue_label_not_enabled");
     }
     Object.assign(base, {
-      trigger: action === "assigned" ? "issue_assigned" : "issue_mention",
+      trigger: "issue_assigned",
       task: {
         kind: "fix_issue",
         issue_number: Number(issue.number || 0),

tests/webhook-adapter.test.ts

@@ -335,7 +335,7 @@ test("example policy routes a labeled issue to the configured familiar", () => {
   );
 
   assert.equal(task.state, "queued");
-  assert.equal(task.trigger, "issue_mention");
+  assert.equal(task.trigger, "issue_assigned");
   assert.deepEqual(task.task, {
     kind: "fix_issue",
     issue_number: 42,
@@ -350,6 +350,49 @@ test("example policy routes a labeled issue to the configured familiar", () => {
   });
 });
 
+test("new issue creation is ignored unless a supported trigger is enabled", () => {
+  const task = buildTaskFromEvent(
+    "issues",
+    "delivery-issue-opened",
+    {
+      action: "opened",
+      installation: {id: 123456},
+      repository: {
+        id: 987654321,
+        full_name: "OpenCoven/example",
+        clone_url: "https://github.com/OpenCoven/example.git",
+        default_branch: "main",
+      },
+      issue: {
+        number: 43,
+        title: "Installer is slow",
+        body: "A diagnostic issue, not a bot task.",
+        labels: [],
+        assignees: [],
+      },
+    } as JsonObject,
+    {
+      enabled_triggers: [
+        "issues.labeled",
+        "issue_comment.created",
+        "pull_request_review_comment.created",
+      ],
+      trigger_labels: ["coven:fix"],
+      bot_usernames: ["coven-cody[bot]"],
+      familiar: {
+        id: "cody",
+        display_name: "Cody",
+        model: "openai/gpt-5.5",
+        skills: [],
+      },
+      publication: {mode: "record_only"},
+    } as JsonObject,
+  );
+
+  assert.equal(task.state, "ignored");
+  assert.equal(task.ignored_reason, "unsupported_issue_action");
+});
+
 test("publication body links screenshot-style file mentions to GitHub blobs", () => {
   const body = publicationCommentBody(
     {