fix: prefer trusted execution receipts

Author: CompleteDotTech

src/adapter.ts

@@ -2728,7 +2728,7 @@ export function trustedValidationFindings(task: JsonObject, receipts: JsonObject
   return findings;
 }
 
-function finalizeReviewResult(resultPath: string, attemptDir: string, receipts: JsonObject[], task: JsonObject): string {
+export function finalizeReviewResult(resultPath: string, attemptDir: string, receipts: JsonObject[], task: JsonObject): string {
   const result = readBoundedRuntimeResult(resultPath);
   const review = {...((result.review as JsonObject | undefined) || {})};
   let findings = Array.isArray(review.findings) ? review.findings : [];
@@ -2742,8 +2742,8 @@ function finalizeReviewResult(resultPath: string, attemptDir: string, receipts:
     workspace_revision: receipt.workspace_revision,
   }));
   const limitations = Array.isArray(review.limitations) ? review.limitations : [];
-  const trustedExecutionPassed = receipts.length > 0 && receipts.every((receipt) => receipt.status === "passed");
-  review.limitations = trustedExecutionPassed
+  const trustedExecutionAvailable = receipts.length > 0;
+  review.limitations = trustedExecutionAvailable
     ? limitations.filter((item) => typeof item !== "string" || !executionOnlyLimitation(item))
     : limitations;
   if (findings.length) review.no_findings_reason = null;

tests/webhook-adapter.test.ts

@@ -14,6 +14,7 @@ import {
   createFreshTaskAttemptDirectory,
   createConfig,
   createFollowupReviewTask,
+  finalizeReviewResult,
   githubRequestAllPages,
   handleRequest,
   inspectRepairDiff,
@@ -1759,6 +1760,27 @@ test("trusted validation derives findings only from failures mapped to verified
   assert.deepEqual(trustedValidationFindings(task, [trustedValidationReceipt()]), []);
 });
 
+test("trusted failed receipts replace model execution disclaimers without hiding substantive limitations", () => {
+  const root = mkdtempSync(join(tmpdir(), "coven-finalize-review-"));
+  const resultPath = join(root, "result.json");
+  const result = completeReview();
+  (result.review as JsonObject).limitations = [
+    "I did not execute the test suite locally.",
+    "The supplied patch for another changed file was truncated.",
+  ];
+  writeFileSync(resultPath, JSON.stringify(result));
+  const task = reviewTask("finalize-failed-receipt");
+  const finalPath = finalizeReviewResult(resultPath, root, [trustedValidationReceipt({
+    returncode: 1,
+    status: "failed",
+    output_summary: "/workspace/src/app.ts:12 validation failed",
+  })], task);
+  const finalized = JSON.parse(readFileSync(finalPath, "utf8")) as JsonObject;
+  const review = finalized.review as JsonObject;
+  assert.deepEqual(review.limitations, ["The supplied patch for another changed file was truncated."]);
+  assert.equal((review.findings as JsonObject[]).length, 1);
+});
+
 test("replaces runtime-authored test claims with trusted host receipts", async () => {
   const stateDir = tempStateDir();
   const config = testConfig(stateDir);