fix deploy review file links

Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>

Author: CompleteDotTech

deploy/coven-github/coven_github_adapter.py

@@ -11,6 +11,7 @@
 from datetime import datetime, timezone
 from pathlib import Path
 from urllib.error import HTTPError
+from urllib.parse import quote
 from urllib.request import Request, urlopen
 
 
@@ -1263,8 +1264,8 @@ def publish_result_if_configured(task, result_path, token):
 
 def publication_comment_body(task, result):
     status = result.get("status") or "unknown"
-    summary = result.get("summary") or "No summary returned."
-    pr_body = result.get("pr_body") or ""
+    summary = link_github_file_mentions(task, result.get("summary") or "No summary returned.")
+    pr_body = link_github_file_mentions(task, result.get("pr_body") or "")
     files_changed = result.get("files_changed") or []
     commits = result.get("commits") or []
     task_id = task.get("task_id") or ""
@@ -1295,10 +1296,14 @@ def publication_comment_body(task, result):
             ]
         )
         if changed_files:
-            parts.append("- Files: {}".format(", ".join("`{}`".format(f) for f in changed_files[:20])))
+            parts.append(
+                "- Files: {}".format(
+                    ", ".join(github_file_markdown(task, f) for f in changed_files[:20])
+                )
+            )
     else:
         parts.append("- No PR review evidence was captured for this run.")
-    parts.extend(structured_review_lines(review))
+    parts.extend(structured_review_lines(review, task))
     parts.extend(
         [
             "",
@@ -1311,6 +1316,89 @@ def publication_comment_body(task, result):
     return "\n".join(parts)
 
 
+def github_blob_base(task):
+    repository = str(task.get("repository") or "").strip()
+    if not re.match(r"^[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+$", repository):
+        return None
+    evidence = task.get("review_evidence") or {}
+    ref = str(
+        evidence.get("head_sha")
+        or evidence.get("workspace_head_sha")
+        or task.get("default_branch")
+        or ""
+    ).strip()
+    if not ref:
+        return None
+    return "https://github.com/{}/blob/{}".format(repository, quote(ref, safe="/"))
+
+
+def parse_repo_relative_path(raw_path):
+    raw = str(raw_path)
+    display = raw.strip()
+    if not display or display != raw or re.search(r"[\s<>]", display):
+        return None
+    if display.startswith(("/", "\\")) or re.match(r"^[A-Za-z]:[\\/]", display):
+        return None
+
+    path = display.replace("\\", "/")
+    line = None
+    line_match = re.match(r"^(.*):(\d+)$", path)
+    if line_match:
+        path = line_match.group(1)
+        line = int(line_match.group(2))
+    if re.match(r"^[A-Za-z][A-Za-z0-9+.-]*:", path):
+        return None
+    while path.startswith("./"):
+        path = path[2:]
+
+    segments = path.split("/")
+    filename = segments[-1] if segments else ""
+    if (
+        not path
+        or "//" in path
+        or any(not segment or segment in {".", ".."} for segment in segments)
+        or not re.search(r"\.[A-Za-z][A-Za-z0-9._-]{0,15}$", filename)
+    ):
+        return None
+    return {"display": display, "path": path, "line": line}
+
+
+def github_file_markdown(task, raw_path, line_override=None):
+    target = parse_repo_relative_path(raw_path)
+    base = github_blob_base(task)
+    if not target or not base:
+        return "`{}`".format(raw_path)
+    encoded_path = "/".join(quote(segment, safe="") for segment in target["path"].split("/"))
+    line = line_override if line_override is not None else target["line"]
+    line_anchor = "#L{}".format(line) if isinstance(line, int) and line > 0 else ""
+    return "[`{}`]({}/{}{})".format(target["display"], base, encoded_path, line_anchor)
+
+
+def link_github_file_mentions(task, text):
+    fence_pattern = re.compile(r"(```[\s\S]*?```)")
+    segments = fence_pattern.split(str(text))
+
+    def replace_segment(segment):
+        def replace_match(match):
+            raw_path = match.group(1)
+            already_link_text = (
+                match.start() > 0
+                and segment[match.start() - 1] == "["
+                and segment[match.end() : match.end() + 2] == "]("
+            )
+            if already_link_text:
+                return match.group(0)
+            linked = github_file_markdown(task, raw_path)
+            return match.group(0) if linked == "`{}`".format(raw_path) else linked
+
+        return re.sub(r"`([^`\n]+)`", replace_match, segment)
+
+    return "".join(
+        segment if index % 2 == 1 else replace_segment(segment)
+        for index, segment in enumerate(segments)
+    )
+
+
 def review_fix_loop_lines(task):
     loops = task.get("review_fix_loops") or []
     if not loops:
@@ -1335,7 +1423,7 @@ def review_fix_loop_lines(task):
     return lines
 
 
-def structured_review_lines(review):
+def structured_review_lines(review, task):
     if not review:
         return ["", "### Structured review", "- No structured review result was emitted."]
 
@@ -1351,7 +1439,7 @@ def structured_review_lines(review):
     if reviewed_files:
         lines.append(
             "- Reviewed file list: {}".format(
-                ", ".join("`{}`".format(path) for path in reviewed_files[:20])
+                ", ".join(github_file_markdown(task, path) for path in reviewed_files[:20])
             )
         )
         if len(reviewed_files) > 20:
@@ -1362,7 +1450,7 @@ def structured_review_lines(review):
     if supporting_files:
         lines.append(
             "- Supporting file list: {}".format(
-                ", ".join("`{}`".format(path) for path in supporting_files[:20])
+                ", ".join(github_file_markdown(task, path) for path in supporting_files[:20])
             )
         )
         if len(supporting_files) > 20:
@@ -1374,11 +1462,12 @@ def structured_review_lines(review):
         location = finding.get("file") or "unknown file"
         if finding.get("line") is not None:
             location = "{}:{}".format(location, finding.get("line"))
+        linked_location = github_file_markdown(task, location, finding.get("line"))
         lines.append(
             "  {}. `{}` {} - {}".format(
                 index,
                 finding.get("severity") or "unknown",
-                location,
+                linked_location,
                 finding.get("title") or "Untitled finding",
             )
         )
@@ -1387,7 +1476,7 @@ def structured_review_lines(review):
 
     no_findings_reason = review.get("no_findings_reason")
     if no_findings_reason:
-        lines.append("- No-findings reason: {}".format(no_findings_reason))
+        lines.append("- No-findings reason: {}".format(link_github_file_mentions(task, no_findings_reason)))
 
     tests_run = review.get("tests_run") or []
     lines.append("- Tests reported by runtime: {}".format(len(tests_run)))

deploy/coven-github/test_coven_github_adapter.py

@@ -79,6 +79,96 @@ def fake_run_command(args, cwd=None, env=None, timeout=300):
             with self.assertRaisesRegex(RuntimeError, "does not match GitHub metadata head"):
                 adapter.prepare_review_context(task, Path(tmp), "tok", {}, Path(tmp))
 
+    def test_publication_body_links_file_mentions(self):
+        adapter = load_adapter()
+
+        body = adapter.publication_comment_body(
+            {
+                "task_id": "task-file-links",
+                "repository": "OpenCoven/coven-github",
+                "default_branch": "main",
+                "review_evidence": {"head_sha": "abc123def456"},
+            },
+            {
+                "status": "success",
+                "summary": "\n".join(
+                    [
+                        "### Files inspected",
+                        "",
+                        "- `src/lib/server/skills-directory.ts`",
+                        "- `README.md:12`",
+                        "- `npm test`",
+                        "",
+                        "```ts",
+                        "`src/not-linked-inside-fence.ts`",
+                        "```",
+                    ]
+                ),
+                "review": {},
+            },
+        )
+
+        self.assertIn(
+            "[`src/lib/server/skills-directory.ts`](https://github.com/OpenCoven/coven-github/blob/abc123def456/src/lib/server/skills-directory.ts)",
+            body,
+        )
+        self.assertIn(
+            "[`README.md:12`](https://github.com/OpenCoven/coven-github/blob/abc123def456/README.md#L12)",
+            body,
+        )
+        self.assertIn("- `npm test`", body)
+        self.assertIn("`src/not-linked-inside-fence.ts`", body)
+        self.assertNotIn("[`src/not-linked-inside-fence.ts`]", body)
+
+    def test_publication_body_links_structured_review_files(self):
+        adapter = load_adapter()
+
+        body = adapter.publication_comment_body(
+            {
+                "task_id": "task-structured-links",
+                "repository": "OpenCoven/coven-github",
+                "default_branch": "main",
+                "review_evidence": {
+                    "head_sha": "feedface",
+                    "changed_files": ["src/app.ts"],
+                    "changed_file_count": 1,
+                },
+            },
+            {
+                "status": "success",
+                "summary": "Done.",
+                "review": {
+                    "mode": "pull_request",
+                    "evidence_status": "complete",
+                    "reviewed_files": ["src/app.ts"],
+                    "supporting_files": ["tests/app.test.ts"],
+                    "findings": [
+                        {
+                            "severity": "medium",
+                            "file": "src/app.ts",
+                            "line": 7,
+                            "title": "Example finding",
+                        }
+                    ],
+                    "no_findings_reason": "Checked `tests/app.test.ts` with `npm test`.",
+                },
+            },
+        )
+
+        self.assertIn(
+            "[`src/app.ts`](https://github.com/OpenCoven/coven-github/blob/feedface/src/app.ts)",
+            body,
+        )
+        self.assertIn(
+            "[`tests/app.test.ts`](https://github.com/OpenCoven/coven-github/blob/feedface/tests/app.test.ts)",
+            body,
+        )
+        self.assertIn(
+            "[`src/app.ts:7`](https://github.com/OpenCoven/coven-github/blob/feedface/src/app.ts#L7)",
+            body,
+        )
+        self.assertIn("with `npm test`", body)
+
 
 if __name__ == "__main__":
     unittest.main()