chore(demo): silence job-control noise on demo shutdown - #41
Merged
Conversation
disown the stub and server after backgrounding so the cleanup kill does not print 'Terminated' lines after the demo's closing summary. Signed-off-by: Val Alexander <bunsthedev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes the offline reference demo shutdown behavior by detaching the backgrounded GitHub stub and adapter processes from job control, aiming to prevent Terminated job-control noise during cleanup.
Changes:
- Disown the demo’s background processes after they’re started to suppress job-control termination messages on shutdown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+117
to
+118
| # Detach both from job control so shutdown doesn't print 'Terminated' noise. | ||
| disown "$STUB_PID" "$SERVER_PID" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish to #40:
disownthe backgrounded stub and adapter so the cleanupkillno longer printsTerminatedjob-control lines after the demo's closing summary.Verified:
examples/demo/run-demo.shexits 0 with 18/18 assertions and zero Terminated lines in captured output.