feat(desktop): route run preferences semantically

Author: hqhq1025

apps/desktop/src/main/ipc/generate.test.ts

@@ -8,8 +8,6 @@ vi.mock('../electron-runtime', () => ({
 import {
   buildRunPreferenceAskInput,
   contextWindowForContextPack,
-  mergeRunPreferenceAnswers,
-  shouldRequestRunPreferencePreflight,
   shouldRunUserMemoryCandidateCapture,
 } from './generate';
 
@@ -49,55 +47,17 @@ describe('generate IPC memory preference helpers', () => {
 });
 
 describe('generate IPC run preference preflight helpers', () => {
-  it('asks fresh designs for tweak preferences', () => {
-    expect(
-      shouldRequestRunPreferencePreflight({
-        hasSource: false,
-        existingPreferences: null,
-        prompt: 'make a dashboard',
-      }),
-    ).toBe(true);
-  });
-
-  it('does not ask again once run preferences are stored', () => {
-    expect(
-      shouldRequestRunPreferencePreflight({
-        hasSource: false,
-        existingPreferences: {
-          schemaVersion: 1,
-          tweaks: 'auto',
-          bitmapAssets: 'auto',
-          reusableSystem: 'auto',
-        },
-        prompt: 'make another screen',
-      }),
-    ).toBe(false);
-  });
-
-  it('updates explicit prompt overrides without preflight', () => {
-    expect(
-      mergeRunPreferenceAnswers(
-        {
-          schemaVersion: 1,
-          tweaks: 'auto',
-          bitmapAssets: 'auto',
-          reusableSystem: 'auto',
-        },
-        [],
-        '不要加微调，也不要生成图片',
-      ),
-    ).toEqual({
-      schemaVersion: 1,
-      tweaks: 'no',
-      bitmapAssets: 'no',
-      reusableSystem: 'auto',
-    });
-  });
-
-  it('builds a required tweaks question for fresh preflight', () => {
-    const input = buildRunPreferenceAskInput('make a landing page');
+  it('builds clarification input from semantic router questions', () => {
+    const input = buildRunPreferenceAskInput([
+      {
+        id: 'bitmapAssets',
+        type: 'text-options',
+        prompt: 'Generate bitmap assets?',
+        options: ['auto', 'no', 'yes'],
+      },
+    ]);
     expect(input.questions[0]).toMatchObject({
-      id: 'tweaks',
+      id: 'bitmapAssets',
       type: 'text-options',
       options: ['auto', 'no', 'yes'],
     });

apps/desktop/src/main/ipc/generate.ts

@@ -1,8 +1,8 @@
 import path_module from 'node:path';
 import {
   type AgentEvent,
-  type AskAnswer,
   type AskInput,
+  applyRunPreferenceAnswers,
   buildApplyCommentUserPrompt,
   buildDesignContextPack,
   type CoreLogger,
@@ -15,14 +15,14 @@ import {
   inspectWorkspaceFiles,
   loadDesignSkills,
   loadFrameTemplates,
+  routeRunPreferences,
   updateDesignSessionBrief,
 } from '@open-codesign/core';
 import { detectProviderFromKey, generateImage } from '@open-codesign/providers';
 import {
   ApplyCommentPayload,
   CancelGenerationPayloadV1,
   CodesignError,
-  type DesignRunPreferencesV1,
   deriveResourceStateFromChatRows,
   GeneratePayloadV1,
 } from '@open-codesign/shared';
@@ -88,65 +88,28 @@ export function shouldRunUserMemoryCandidateCapture(prefs: {
   return prefs.memoryEnabled === true && prefs.userMemoryAutoUpdate === true;
 }
 
-const DEFAULT_RUN_PREFERENCES: DesignRunPreferencesV1 = {
-  schemaVersion: 1,
-  tweaks: 'auto',
-  bitmapAssets: 'auto',
-  reusableSystem: 'auto',
-};
-
-export function shouldRequestRunPreferencePreflight(input: {
-  hasSource: boolean;
-  existingPreferences: DesignRunPreferencesV1 | null;
-  prompt: string;
-}): boolean {
-  if (input.existingPreferences !== null) return false;
-  if (input.hasSource) return false;
-  return input.prompt.trim().length > 0;
-}
-
-export function buildRunPreferenceAskInput(_prompt: string): AskInput {
+export function buildRunPreferenceAskInput(questions: AskInput['questions']): AskInput {
   return {
     rationale: 'A few setup choices help Open CoDesign avoid unnecessary work.',
-    questions: [
-      {
-        id: 'tweaks',
-        type: 'text-options',
-        prompt: 'Do you want tweak controls for this design?',
-        options: ['auto', 'no', 'yes'],
-      },
-    ],
+    questions,
   };
 }
 
-function answerValue(answers: AskAnswer[], questionId: string): string | null {
-  const value = answers.find((answer) => answer.questionId === questionId)?.value;
-  return typeof value === 'string' ? value : null;
-}
-
-export function mergeRunPreferenceAnswers(
-  base: DesignRunPreferencesV1 | null,
-  answers: AskAnswer[],
-  prompt: string,
-): DesignRunPreferencesV1 {
-  const next: DesignRunPreferencesV1 = { ...(base ?? DEFAULT_RUN_PREFERENCES) };
-  const tweakAnswer = answerValue(answers, 'tweaks');
-  if (tweakAnswer === 'yes' || tweakAnswer === 'no' || tweakAnswer === 'auto') {
-    next.tweaks = tweakAnswer;
-  }
-  const lower = prompt.toLowerCase();
-  const disablesTweaks = /不要.*微调|不.*微调|no tweaks?|without tweaks?/.test(lower);
-  if (disablesTweaks) {
-    next.tweaks = 'no';
-  } else if (/加.*微调|要.*微调|add tweaks?|with tweaks?/.test(lower)) {
-    next.tweaks = 'yes';
-  }
-  if (/不要.*(图片|图像)|不.*生成.*(图片|图像)|no images?|without images?/.test(lower)) {
-    next.bitmapAssets = 'no';
-  } else if (/生成.*(图片|图像)|加.*(图片|图像)|generate images?|with images?/.test(lower)) {
-    next.bitmapAssets = 'yes';
-  }
-  return next;
+function recentHistoryForRunPreferenceRouter(
+  chatRows: ReturnType<typeof listSessionChatMessages>,
+): string {
+  return chatRows
+    .slice(-12)
+    .map((row) => {
+      if (row.kind !== 'user' && row.kind !== 'assistant_text') return null;
+      const text =
+        typeof (row.payload as { text?: unknown }).text === 'string'
+          ? (row.payload as { text: string }).text
+          : '';
+      return text.trim().length > 0 ? `[${row.kind}] ${text.trim().slice(0, 800)}` : null;
+    })
+    .filter((line): line is string => line !== null)
+    .join('\n');
 }
 
 function designMdSummaryForMemory(
@@ -797,27 +760,42 @@ export function registerGenerateIpc({ db, getMainWindow }: RegisterGenerateIpcDe
               runPreferenceStoreOptions !== null
                 ? readSessionRunPreferences(runPreferenceStoreOptions, designId)
                 : null;
-            let runPreferences = mergeRunPreferenceAnswers(
-              existingRunPreferences,
-              [],
-              payload.prompt,
-            );
-            if (
-              shouldRequestRunPreferencePreflight({
-                hasSource: Boolean(payload.previousSource?.trim()),
-                existingPreferences: existingRunPreferences,
-                prompt: payload.prompt,
-              })
-            ) {
+            const workspaceState = {
+              sourcePath: payload.previousSource ? 'App.jsx' : null,
+              hasSource: Boolean(payload.previousSource?.trim()),
+              hasDesignMd: Boolean(promptContext.projectContext.designMd?.trim()),
+              hasAgentsMd: Boolean(promptContext.projectContext.agentsMd?.trim()),
+              hasSettingsJson: Boolean(promptContext.projectContext.settingsJson?.trim()),
+            };
+            const routedPreferences = await routeRunPreferences({
+              prompt: payload.prompt,
+              existingPreferences: existingRunPreferences,
+              recentHistory: recentHistoryForRunPreferenceRouter(chatRows),
+              workspaceState,
+              designBrief: existingBrief ? JSON.stringify(existingBrief) : null,
+              userMemory: memoryContext?.userMemory?.content ?? null,
+              workspaceMemory: memoryContext?.workspaceMemory?.content ?? null,
+              model: active.model,
+              apiKey,
+              ...(baseUrl !== undefined ? { baseUrl } : {}),
+              wire: active.wire,
+              ...(active.httpHeaders !== undefined ? { httpHeaders: active.httpHeaders } : {}),
+              ...(active.reasoningLevel !== undefined
+                ? { reasoningLevel: active.reasoningLevel }
+                : {}),
+              ...(allowKeyless ? { allowKeyless: true } : {}),
+              logger: coreLogger,
+            });
+            let runPreferences = routedPreferences.preferences;
+            if (routedPreferences.needsClarification && routedPreferences.clarificationQuestions) {
               const askResult = await requestAsk(
                 id,
-                buildRunPreferenceAskInput(payload.prompt),
+                buildRunPreferenceAskInput(routedPreferences.clarificationQuestions),
                 () => getMainWindow(),
               );
-              runPreferences = mergeRunPreferenceAnswers(
+              runPreferences = applyRunPreferenceAnswers(
                 runPreferences,
                 askResult.status === 'answered' ? askResult.answers : [],
-                payload.prompt,
               );
             }
             if (runPreferenceStoreOptions !== null) {

packages/core/src/agent.test.ts

@@ -1466,15 +1466,17 @@ describe('generateViaAgent()', () => {
     expect(sys).toContain('Prefer progressive generation');
     expect(sys).toContain('coherent first pass');
     expect(sys).toContain('complete first pass');
-    expect(sys).toContain('Do not call `preview` while the artifact is still only a scaffold');
-    expect(sys).toContain('A complete `create App.jsx` is acceptable');
+    expect(sys).toContain(
+      'Do not call `preview` while a previewable artifact is still only a scaffold',
+    );
+    expect(sys).toContain('A complete first `create` is acceptable');
     expect(sys).toContain('Interleave major tool groups');
     expect(sys).toContain('under 18 words');
     expect(sys).toContain('`str_replace`, or `insert`');
     expect(sys).toContain('Do not emit `<artifact>`');
     expect(sys).toContain('design source to `App.jsx`');
     expect(sys).toContain('Local workspace assets and scaffolded files are allowed');
-    expect(sys).toContain('Call `done(path)` after the final mutation');
+    expect(sys).toContain('`done(path)` after the final mutation');
     expect(sys).toContain('stop after 3 error rounds');
     expect(sys).not.toContain('text_editor.create(');
     expect(sys).not.toContain('view("index.html"');
@@ -1541,7 +1543,7 @@ describe('generateViaAgent()', () => {
     expect(names).not.toContain('verify_html');
   });
 
-  it('hides tweaks and image tools when the feature profile disables them', async () => {
+  it('hides tweaks and image tools only for explicit high-confidence refusals', async () => {
     scriptedAgent = { assistantText: RESPONSE_WITH_ARTIFACT };
     await generateViaAgent(
       {
@@ -1554,6 +1556,10 @@ describe('generateViaAgent()', () => {
           tweaks: 'no',
           bitmapAssets: 'no',
           reusableSystem: 'auto',
+          routing: {
+            tweaks: { provenance: 'explicit', confidence: 'high' },
+            bitmapAssets: { provenance: 'explicit', confidence: 'high' },
+          },
         },
         runPreview: async () => ({
           ok: true,
@@ -1584,6 +1590,47 @@ describe('generateViaAgent()', () => {
     expect(sys).not.toContain('Bitmap asset generation');
   });
 
+  it('keeps semantic tools available for inferred low-confidence refusals', async () => {
+    scriptedAgent = { assistantText: RESPONSE_WITH_ARTIFACT };
+    await generateViaAgent(
+      {
+        prompt: 'design a landing page',
+        history: [],
+        model: MODEL,
+        apiKey: 'sk-test',
+        runPreferences: {
+          schemaVersion: 1,
+          tweaks: 'no',
+          bitmapAssets: 'no',
+          reusableSystem: 'auto',
+          routing: {
+            tweaks: { provenance: 'inferred', confidence: 'low' },
+            bitmapAssets: { provenance: 'inferred', confidence: 'low' },
+          },
+        },
+        readWorkspaceFiles: async () => [],
+      },
+      {
+        fs: makeStubFs({ 'App.jsx': SAMPLE_HTML }),
+        generateImageAsset: async () => ({
+          path: 'assets/hero.png',
+          dataUrl: 'data:image/png;base64,aW1n',
+          mimeType: 'image/png',
+          model: 'gpt-image-2',
+          provider: 'openai',
+        }),
+      },
+    );
+
+    const tools = (agentCalls[0]?.options.initialState?.tools ?? []) as Array<{ name?: string }>;
+    const names = tools.map((tool) => tool.name);
+    expect(names).toContain('tweaks');
+    expect(names).toContain('generate_image_asset');
+    const sys = agentCalls[0]?.options.initialState?.systemPrompt as string;
+    expect(sys).toContain('User-routed preferences');
+    expect(sys).not.toContain('The user explicitly declined');
+  });
+
   it('keeps selective tweaks guidance in auto mode', async () => {
     scriptedAgent = { assistantText: RESPONSE_WITH_ARTIFACT };
     await generateViaAgent({
@@ -1599,7 +1646,7 @@ describe('generateViaAgent()', () => {
       },
     });
     const sys = agentCalls[0]?.options.initialState?.systemPrompt as string;
-    expect(sys).toContain('Call `tweaks()` only when user preference allows');
+    expect(sys).toContain('decide agentically whether tweak controls improve iteration');
   });
 
   it('injects apply-comment supporting context only once through the agent boundary', async () => {