Commit fe42888
committed
fix(decompose): address bot follow-up review (3 minor + 1 stale-diff false alarm)
Follow-up review (commit e1afcdf, 2026-05-01T21:19) flagged 5 items.
Triage:
- [Major false alarm] Scope creep: bot claimed extensive .github/* changes
in this PR. Verified `git diff --name-only upstream/main..HEAD` — zero
.github/* files in the actual diff. Bot was looking at a stale snapshot
before the merge with upstream/main propagated. Will note this in the
reply on the PR.
- [Major] PR body still said `Closes #225 (Phase 1 only)` even though
the changeset was updated to `Refs #225`. Per PULL_REQUEST_TEMPLATE.md,
`Closes` only fully resolves; this PR is Phase 1 of a multi-phase
feature. Edited PR body via `gh pr edit` — `Closes #225` → `Refs #225`
in the linked-issue line, and "This PR closes the Phase 1 part of #225"
→ "This PR addresses Phase 1 of #225".
- [Minor] Three changesets where convention is one. Consolidated
`feat-decompose-to-ui-kit.md` + `feat-verify-ui-kit-visual-parity.md`
into the existing `decompose-to-ui-kit.md` (which already had the
correct `Refs #225` wording from the previous fix pass). Now one
changeset, comprehensive description, all 3 packages bumped consistently.
- [Minor] README image URLs pointed at the fork's feature branch
(`raw.githubusercontent.com/HomenShum/open-codesign/feat/decompose-to-ui-kit/...`)
which would 404 after merge. Repointed both EN + ZH-CN README images
at `OpenCoworkAI/open-codesign/main/...` so they keep working post-merge.
- [Minor] `dataUrlToBase64` used `dataUrl.indexOf('base64,')` — case-
sensitive. RFC 2397 specifies `;base64` token is case-insensitive in
practice (browsers accept both). Switched to a case-insensitive regex
match (`/;base64,/i`). Throws same error message on miss; logic
identical for canonical lowercase inputs.
Verification:
- apps/desktop: pnpm typecheck (node + web tsconfig) clean
- packages/core: pnpm typecheck clean1 parent e1afcdf commit fe42888
6 files changed
Lines changed: 23 additions & 34 deletions
File tree
- .changeset
- apps/desktop/src/main
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
8 | 16 | | |
9 | 17 | | |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
232 | 232 | | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
| 238 | + | |
| 239 | + | |
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
233 | | - | |
| 233 | + | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
237 | | - | |
| 236 | + | |
| 237 | + | |
238 | 238 | | |
239 | 239 | | |
240 | 240 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
155 | | - | |
156 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
157 | 162 | | |
158 | 163 | | |
159 | 164 | | |
| |||
0 commit comments