bug: Scaffold manifest validation fails — 'iphone-frame.source must be a non-empty string'

[Sun-sunshine06]

Description

The scaffold manifest validation rejects the iphone-frame scaffold because its source field fails validation (must be a non-empty string). This appears 4 times across multiple dates in the logs.

Log Evidence

From main.log:

[2026-04-23 ...] error: manifest.scaffolds.iphone-frame.source must be a non-empty string
[2026-04-24 ...] error: manifest.scaffolds.iphone-frame.source must be a non-empty string
[2026-04-25 ...] error: manifest.scaffolds.iphone-frame.source must be a non-empty string
[2026-05-04 ...] error: manifest.scaffolds.iphone-frame.source must be a non-empty string

Reproduction

Every app startup triggers manifest validation. If the iphone-frame scaffold entry has an empty or missing source field in its manifest, validation fails.

Environment

• Version: v0.2 (experimental)
• Platform: Windows 11

Likely Cause

The scaffold manifest file defines an iphone-frame scaffold with either a missing or empty source property. The schema requires a non-empty string.

Impact

The iphone-frame scaffold is unavailable for use. Non-blocking (app continues), but the scaffold cannot be loaded.

[github-actions]

Thank you for this detailed bug report, @Sun-sunshine06.

The error manifest.scaffolds.iphone-frame.source must be a non-empty string indicates that the scaffold manifest validation is working correctly — it's catching a manifest entry with an empty or missing source field. This is a configuration issue in the scaffold definition itself.

Relevant code:

• Scaffold manifests are defined in apps/desktop/resources/templates/scaffolds.json (or a similar manifest file under apps/desktop/resources/templates/) — see AGENTS.md mention of "31 scaffold manifest entries".
• The validation schema likely lives in packages/shared/src/scaffold.ts (or a similar file) where the source property is typed as a non-empty string via a zod schema.

Suggested fix:
Check the iphone-frame entry in the scaffold manifest file. The source field should be a non-empty string pointing to a valid scaffold directory or URL. For example, it might look like:

{
  "scaffolds": {
    "iphone-frame": {
      "source": "scaffolds/iphone-frame",
      "description": "iPhone frame template",
      ...
    }
  }
}

If the source is missing or set to "", it will fail validation. Could you share the contents of the relevant manifest file (e.g., apps/desktop/resources/templates/scaffolds.json) to confirm the exact issue? That would help identify whether this is a packaging error (missing file) or a manifest definition error.

This is a non-blocking error for app startup, but it prevents the iphone-frame scaffold from being loaded. Thanks again for reporting — we'll get this fixed.

---

Open-CoDesign Bot

[Sun-sunshine06]

已在 PR #300 中修复并合并到 main。

当前 bundled scaffold manifest 里的 iphone-frame.source 已是非空；这次修复的是升级场景中用户数据目录保留下来的旧 templates/scaffolds/manifest.json。启动时模板 ensure 会用 bundled manifest 修补内置 scaffold 缺失或空的元数据字段（包括 source），同时保留用户自定义 scaffold 和有效的用户编辑。验证包含 targeted Biome、ensure-user-templates 单测、core scaffold/resource-manifest 单测、desktop typecheck 和全仓 typecheck。