feat: add confirmation dialog for track deletion (#738)#755
feat: add confirmation dialog for track deletion (#738)#755Vitalcheffe wants to merge 1 commit intoOpenCut-app:mainfrom
Conversation
Right-click → Delete track now shows an AlertDialog with element count before removing. Prevents accidental destruction of tracks with many clips. Fixes OpenCut-app#738
|
@Vitalcheffe is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA confirmation dialog was added to the timeline track deletion flow. When users click "Delete track," a modal dialog now prompts for confirmation instead of immediately removing the track. Canceling dismisses the dialog; confirming proceeds with the deletion. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Right-click → Delete track immediately destroys the track with all its clips, no confirmation. One misclick can destroy a complex edit.
Solution
Added an AlertDialog (matching the existing DeleteDialog pattern from
scenes-view.tsx) that shows element count before confirming:@radix-uiAlertDialog componentChanges
apps/web/src/components/editor/panels/timeline/index.tsx:trackToDeletestate to track pending deletionremoveTrack()call with state setterFixes #738
Summary by CodeRabbit
Release Notes