Skip to content

feat: add confirmation dialog for track deletion (#738) #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vitalcheffe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add confirmation dialog for track deletion (#738) #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion apps/web/src/components/editor/panels/timeline/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,16 @@ import {
ContextMenuItem,
ContextMenuTrigger,
} from "@/components/ui/context-menu";
import {
AlertDialog,
AlertDialogAction,
AlertDialogCancel,
AlertDialogContent,
AlertDialogDescription,
AlertDialogFooter,
AlertDialogHeader,
AlertDialogTitle,
} from "@/components/ui/alert-dialog";
import { useTimelineZoom } from "@/hooks/timeline/use-timeline-zoom";
import {
useCallback,
Expand Down Expand Up @@ -675,6 +685,7 @@ function TimelineTrackRows({
const timeline = useEditor((e) => e.timeline);
const tracks = useEditor((e) => e.timeline.getTracks());
const { selectedElements } = useElementSelection();
const [trackToDelete, setTrackToDelete] = useState<TimelineTrack | null>(null);
const tracksWithSelection = useMemo(
() => new Set(selectedElements.map((el) => el.trackId)),
[selectedElements],
Expand Down Expand Up @@ -773,7 +784,7 @@ function TimelineTrackRows({
icon={<HugeiconsIcon icon={Delete02Icon} />}
onClick={(event: React.MouseEvent) => {
event.stopPropagation();
timeline.removeTrack({ trackId: track.id });
setTrackToDelete(track);
}}
variant="destructive"
>
Expand All @@ -783,6 +794,30 @@ function TimelineTrackRows({
</ContextMenuContent>
</ContextMenu>
))}
{trackToDelete && (
<AlertDialog open onOpenChange={(open) => !open && setTrackToDelete(null)}>
<AlertDialogContent>
<AlertDialogHeader>
<AlertDialogTitle>Delete track?</AlertDialogTitle>
<AlertDialogDescription>
This will remove {trackToDelete.elements.length} element{trackToDelete.elements.length === 1 ? "" : "s"}.
This action cannot be undone.
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogFooter>
<AlertDialogCancel>Cancel</AlertDialogCancel>
<AlertDialogAction
onClick={() => {
timeline.removeTrack({ trackId: trackToDelete.id });
setTrackToDelete(null);
}}
>
Delete
</AlertDialogAction>
</AlertDialogFooter>
</AlertDialogContent>
</AlertDialog>
)}
</>
);
}
Expand Down