rx: remove unused redundant_iface_index

Author: coderkalyan

libserard/serard.c

@@ -689,7 +689,6 @@ SERARD_PRIVATE int8_t rxAcceptByte(struct SerardRx* const          ins,
                                    struct SerardReassembler* const reassembler,
                                    const SerardMicrosecond         timestamp_usec,
                                    const uint8_t                   payload_byte,
-                                   const uint8_t                   redundant_iface_index,
                                    struct SerardRxTransfer* const  out_transfer)
 {
     int8_t                      ret           = 0;
@@ -709,7 +708,6 @@ SERARD_PRIVATE int8_t rxAcceptByte(struct SerardRx* const          ins,
         {
             // if the state machine is accepting the payload, try to accept
             // the received transfer payload and return to the user
-            // FIXME: what is the redundant interface index for?
             ret = rxAcceptTransfer(ins, reassembler, out_transfer);
             if (ret == 1)
             {
@@ -934,7 +932,6 @@ int8_t serardRxAccept(struct SerardRx* const              ins,
                       SerardMicrosecond const             timestamp_usec,
                       size_t* const                       inout_payload_size,
                       const uint8_t* const                payload,
-                      const uint8_t                       redundant_transport_index,
                       struct SerardRxTransfer* const      out_transfer,
                       struct SerardRxSubscription** const out_subscription)
 {
@@ -945,8 +942,7 @@ int8_t serardRxAccept(struct SerardRx* const              ins,
     for (size_t i = 0; i < in_payload_size; i++)
     {
         const uint8_t payload_byte = payload[i];
-        const int8_t  out =
-            rxAcceptByte(ins, reassembler, timestamp_usec, payload_byte, redundant_transport_index, out_transfer);
+        const int8_t  out          = rxAcceptByte(ins, reassembler, timestamp_usec, payload_byte, out_transfer);
         if (out != 0)
         {
             if (out < 0)

libserard/serard.h

@@ -351,7 +351,6 @@ int8_t serardRxAccept(struct SerardRx* const              ins,
                       const SerardMicrosecond             timestamp_usec,
                       size_t* const                       inout_payload_size,
                       const uint8_t* const                payload,
-                      const uint8_t                       redundant_transport_index,
                       struct SerardRxTransfer* const      out_transfer,
                       struct SerardRxSubscription** const out_subscription);
 

tests/exposed.hpp

@@ -27,7 +27,6 @@ struct RxSession
     SerardMicrosecond transfer_timestamp_usec = std::numeric_limits<std::uint64_t>::max();
     SerardTransferID  transfer_id             = std::numeric_limits<std::uint8_t>::max();
     SerardNodeID      source_node_id          = 0U;
-    std::uint8_t      redundant_iface_index   = std::numeric_limits<std::uint8_t>::max();
 };
 
 struct CobsEncoder
@@ -91,17 +90,14 @@ auto               txMakeHeader(const SerardNodeID                         node_
 auto               rxSessionUpdate(struct SerardRx* const                ins,
                                    struct SerardInternalRxSession* const rxs,
                                    const struct SerardRxTransfer* const  transfer,
-                                   const std::uint8_t                    redundant_iface_index,
                                    const SerardMicrosecond               transfer_id_timeout_usec) -> void;
 [[nodiscard]] auto rxAcceptTransfer(struct SerardRx* const          ins,
                                     struct SerardReassembler* const reassembler,
-                                    struct SerardRxTransfer* const  transfer,
-                                    const std::uint8_t              redundant_iface_index) -> std::int8_t;
+                                    struct SerardRxTransfer* const  transfer) -> std::int8_t;
 [[nodiscard]] auto rxAcceptByte(struct SerardRx* const          ins,
                                 struct SerardReassembler* const reassembler,
                                 const SerardMicrosecond         timestamp_usec,
                                 const std::uint8_t              payload_byte,
-                                const std::uint8_t              redundant_iface_index,
                                 struct SerardRxTransfer* const  out_transfer) -> std::int8_t;
 }
 }  // namespace exposed

tests/test_private.cpp

@@ -562,7 +562,7 @@ TEST_CASE("rxValidateHeader")
         const std::array<std::uint8_t, 24> buffer      = {0x01, 0x07, 0xD2, 0x04, 0xE1, 0x10, 0xEA, 0xC0,
                                                           0xBA, 0xB0, 0xFE, 0xCA, 0x00, 0x00, 0x00, 0x00,
                                                           0x00, 0x00, 0x00, 0x80, 0x00, 0x00, 0xDB, 0x89};
-        std::copy(buffer.begin(), buffer.end(), reassembler.header);
+        std::copy(buffer.begin(), buffer.end(), &reassembler.header[0]);
         reassembler.counter = buffer.size() - 1;
 
         struct SerardRxTransfer transfer = {};
@@ -585,7 +585,7 @@ TEST_CASE("rxValidateHeader")
         const std::array<std::uint8_t, 24> buffer      = {0x01, 0x07, 0xD2, 0x04, 0xE1, 0x10, 0xEA, 0xC0,
                                                           0xBA, 0xB0, 0xFE, 0xCA, 0x00, 0x00, 0x00, 0x00,
                                                           0x00, 0x00, 0x00, 0x80, 0x00, 0x00, 0xDB, 0x89};
-        std::copy(buffer.begin(), buffer.end(), reassembler.header);
+        std::copy(buffer.begin(), buffer.end(), &reassembler.header[0]);
         reassembler.counter = buffer.size() - 1;
 
         struct SerardRxTransfer transfer = {};

tests/test_public.cpp

@@ -117,7 +117,7 @@ TEST_CASE("serardRxAccept")
     size_t                payload_size = buffer.size();
     SerardRxTransfer      out          = {};
     SerardRxSubscription* out_sub      = nullptr;
-    const int8_t          ret = serardRxAccept(&ins, &reassembler, 0, &payload_size, buffer.data(), 0, &out, &out_sub);
+    const int8_t          ret = serardRxAccept(&ins, &reassembler, 0, &payload_size, buffer.data(), &out, &out_sub);
     REQUIRE(ret == 1);
 
     // struct SerardTransferMetadata metadata = {