fix: prevent failures on clean Linux builds#2022
Merged
smathermather merged 1 commit intoOpenDroneMap:masterfrom Apr 22, 2026
Merged
fix: prevent failures on clean Linux builds#2022smathermather merged 1 commit intoOpenDroneMap:masterfrom
smathermather merged 1 commit intoOpenDroneMap:masterfrom
Conversation
While trying to build the project from clean there were a couple of issues I encountered. - Ceres didn't build due to the `git patch` command failing. - GDAL didn't install the python bindings in the venv With these changes I can consistently build the project from scratch. I've tested this by using a clean Docker build and also with a devcontainer (both using ubuntu 24.04).
Contributor
|
Shouldn't affect Windows and Mac, but double-checking. Built on linux and ran through oats as a quick check. Will take a look at outputs in detail later tonight, but cursory checks are good. |
sylveon
approved these changes
Apr 22, 2026
Contributor
sylveon
left a comment
sylveon
left a comment
There was a problem hiding this comment.
Tested on Windows, everything still works there!
Contributor
|
Cool. Works better on linux than 2.5.6 as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to build the project from clean there were a few issues I encountered:
git patchcommand failing./codedirectory doesn't exist which was causing the configure.sh script to failWith these changes I can consistently build the project from scratch. I've tested this by using a clean Docker build and also with a devcontainer (both using ubuntu 24.04).
I believe these changes shouldn't affect windows and mac builds but I don't have machines to test those at the moment.