feat: prefetch assets#44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new top-level configuration flag to control whether models/datasets are pre-fetched on the login node before SLURM submission, and updates the submission script + documentation so prefetching can run independently of offline mode (enabled by default, with opt-out).
Changes:
- Add
prefetch_assets: bool = TruetoPostTrainingConfig. - Update
scripts/submit.pyso the prefetch step runs whenofflineorprefetch_assetsis true. - Document the new
prefetch_assetsflag and add it to the example config inREADME.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/post_training/config.py | Adds prefetch_assets flag (default True) to the root config schema. |
| scripts/submit.py | Runs login-node prefetch when offline or prefetch_assets is enabled. |
| README.md | Documents prefetch behavior and adds prefetch_assets to the sample config. |
Comments suppressed due to low confidence (1)
scripts/submit.py:122
- The prefetch log message is now misleading: this block runs when either
offlineorprefetch_assetsis true, but it always logsoffline=True. This will confuse users who haveoffline: falseand are only using prefetching.
logger.info(
"offline=True: pre-fetching models and datasets on the login node "
"before submitting the job."
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
prefetch_assets: bool = Truefield toPostTrainingConfig(src/post_training/config.py) and updatesscripts/submit.pyso the login-node prefetch step (HF cache env application +prefetch_assets(config)) runs wheneverconfig.offlineorconfig.prefetch_assetsis true. Previously prefetching only ran underoffline: true; it's now on by default independent of offline mode, with an opt-out viaprefetch_assets: false.Type of change
Validation
Describe how this change was verified.