Avoid converting empty GET bodies to POST#3463
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Signed-off-by: hutiefang <hutiefang@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2872.
When the default client sends a GET request with a non-null but empty body, HttpURLConnection treats setDoOutput(true) as a signal that output will be written. That can silently turn the request into POST before it reaches the server.
This keeps the existing behavior for non-empty bodies and for methods that normally send bodies, but skips writing an empty body for GET requests so the method stays GET.
Validation:
new byte[0]as the body and verifies MockWebServer receives GET.expected: "GET" but was: "POST".JAVA_HOME=$(/usr/libexec/java_home -v 26) ./mvnw -pl core testgit diff --check