Centralize all version properties in parent POM#1433
Closed
Conversation
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 813 838 +25
Lines 31465 31795 +330
Branches 3600 3608 +8
=======================================
- Misses 31465 31795 +330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Added 40+ additional version properties to parent POM - Updated all child module POMs in querydsl-libraries/ and querydsl-tooling/ - All hardcoded versions now use property references - Build validated successfully Signed-off-by: Marvin Froeder <velo.br@gmail.com>
- querydsl-jpa-codegen was incorrectly using hibernate6.version for expressly dependency - Removed unused hibernate6.version property - expressly.version is the correct property (both are 6.0.0 but semantically different) Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Issues fixed: - jdepend was using json-path.version (2.9.1) instead of jdepend.version - cubrid-jdbc-driver was using jmolecules.version instead of cubrid-packaging.version - r2dbc-postgresql was using r2dbc-h2.version instead of r2dbc-postgresql.version - jmh-core/jmh-generator-annprocess were using jmh-generator.version instead of jmh.version All dependencies now use semantically correct property names Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Contributor
|
This pull request has been marked as stale due to inactivity. |
Contributor
|
This pull request has been closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR centralizes all hardcoded version numbers to properties in the parent POM, improving maintainability and making version upgrades easier across the multi-module project.
Changes
Parent POM (
pom.xml)Added 52 new version properties organized into three categories:
Maven Plugin Versions (18 properties):
Other Plugin Versions (9 properties):
Dependency Versions (11 properties):
Child Module POMs
querydsl-libraries/querydsl-sql/pom.xml: Updated postgis-jdbc version referencequerydsl-libraries/querydsl-scala/pom.xml: Updated jakarta.inject-api version referenceBenefits
Testing
./mvnw validateFiles Changed
pom.xml(121 lines changed)querydsl-libraries/querydsl-sql/pom.xml(2 lines changed)querydsl-libraries/querydsl-scala/pom.xml(2 lines changed)