Skip to content

Commit 331b6c5

Browse files
Remove double promise from twilio sendsms helper (#1630)
* remove double promise * changeset * Remove console.log * versions --------- Co-authored-by: Joe Clark <joe@openfn.org>
1 parent e180d55 commit 331b6c5

4 files changed

Lines changed: 17 additions & 16 deletions

File tree

packages/siuben-rd/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# @openfn/language-siuben-rd
22

3-
## 1.0.0
3+
## 1.0.0 - 02 April 2026
44

55
Initial release of SIUBEN adaptor with GET HTTP request and authentication.

packages/twilio/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# @openfn/language-twilio
22

3+
## 1.0.11 - 02 April 2026
4+
5+
### Patch Changes
6+
7+
- f29c8d8: Remove double promise to sendsms function
8+
39
## 1.0.10 - 30 March 2026
410

511
### Patch Changes

packages/twilio/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@openfn/language-twilio",
33
"label": "Twilio",
4-
"version": "1.0.10",
4+
"version": "1.0.11",
55
"description": "OpenFn adaptor for Twilio",
66
"main": "dist/index.cjs",
77
"scripts": {

packages/twilio/src/Adaptor.js

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { execute as commonExecute } from '@openfn/language-common';
1+
import { execute as commonExecute, composeNextState } from '@openfn/language-common';
22
import { expandReferences } from '@openfn/language-common/util';
33

44
/**
@@ -48,19 +48,14 @@ export function sendSMS(params) {
4848

4949
const client = require('twilio')(accountSid, authToken);
5050

51-
return new Promise((resolve, reject) => {
52-
client.messages
53-
.create({ body, from, to })
54-
.then(response => {
55-
if (response.errorCode) {
56-
console.log(response);
57-
reject(response.errorCode);
58-
}
59-
console.log(response);
60-
return response;
61-
})
62-
.done();
63-
});
51+
return client.messages
52+
.create({ body, from, to })
53+
.then(response => {
54+
if (response.errorCode) {
55+
throw response.errorCode;
56+
}
57+
return composeNextState(state, response);
58+
});
6459
};
6560
}
6661

0 commit comments

Comments
 (0)