fhir-gen: Add tests against fhir code generator #1619
Merged
josephjclark merged 6 commits intomainfrom Apr 7, 2026
Merged
Conversation
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
Contributor
Author
|
@josephjclark I have fixed the comments |
Signed-off-by: Hunter Achieng <achienghunter@gmail.com>
josephjclark
approved these changes
Apr 7, 2026
Collaborator
josephjclark
left a comment
josephjclark
left a comment
There was a problem hiding this comment.
Looks great. We'll need to add more tests over time but let's merge this for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests against fhir code generator.
generateCode()Returns{ profiles. ...rest}.profilesis a string an cannot be used as a builder function.To use builders, we have to have a code eval to check agains the outputs.
To keep it simple, we started with checking the validity of the returned string.
Fixes #
Details
Add technical details of what you've changed (and why).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.