fhir: map primitive elements by hunterachieng · Pull Request #1678 · OpenFn/adaptors

hunterachieng · 2026-05-26T13:10:00Z

Summary

Add ability to map primitive elements in fhir by focusing on elements starting with an _.
Regenerated fhir-eswatini with tests to check behavior

Ensured we do not throw away primitive elements in generate-schema then mapped by checking if the parent has an extension.

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

I have used Claude Code
I have used another model
I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

Does the PR do what it claims to do?
If this is a new adaptor, added the adaptor on marketing website ?
If this PR includes breaking changes, do we need to update any jobs in
production? Is it safe to release?
Are there any unit tests?
Is there a changeset associated with this PR? Should there be? Note that
dev only changes don't need a changeset.
Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

josephjclark

Maybe a bit of confusion over whether we're handling primitve types or primitive extensions? I'm expecting that primitive types work already, and we're just adding support for extensions here

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

…hir-underscores Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

…ptors into feature/1557-fhir-underscores

…rk:OpenFn/adaptors into feature/1557-fhir-underscores

* bump sdk (#1708) * DHIS2: Schema should not require username/password when using a PAT (#1689) * fix(auth): check credential values not just key presence, make username/password optional in schema * changeset file * Revised the auth tests to be more descriptive * build(deps): bump undici from 7.24.7 to 7.28.0 (#1694) * build(deps): bump undici from 7.24.7 to 7.28.0 Bumps [undici](https://github.com/nodejs/undici) from 7.24.7 to 7.28.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.24.7...v7.28.0) --- updated-dependencies: - dependency-name: undici dependency-version: 7.28.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * changeset --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joe Clark <joe@openfn.org> * build(deps): bump esbuild from 0.27.4 to 0.28.1 (#1693) Bumps [esbuild](https://github.com/evanw/esbuild) from 0.27.4 to 0.28.1. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.27.4...v0.28.1) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.28.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * dhis2: Add paging examples and default `async:false` in `tracker.import` (#1681) * feat: allow async value change Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: update tests Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: add changeset Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * add integration tests for tracker.export * add pagination example * update example * update integration test * improve format * remove async and add pagination docs * update tracker unit tests * update changeset * fix typo * fix: update chngeset and tracker pagination examples Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix: update docs Signed-off-by: Hunter Achieng <achienghunter@gmail.com> --------- Signed-off-by: Hunter Achieng <achienghunter@gmail.com> Co-authored-by: Emmanuel Evance <mtuchidev@gmail.com> * fhir: map primitive elements (#1678) * feat: implement primitive mappings Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: update comments Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix tests Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: update fhir-eswatini Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix: remove skipped tests Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: fix primp value renaming Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix: package.json Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * feat: rebuild fhir-eswatini Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix: remove nested `_birthTime` Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * fix: add tests Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * clean up tests * remove comment * fix: add tests and update docs Signed-off-by: Hunter Achieng <achienghunter@gmail.com> * bump fhir-gen tool * fhir-eswatini: update build meta * changeset --------- Signed-off-by: Hunter Achieng <achienghunter@gmail.com> Co-authored-by: Joe Clark <joe@openfn.org> * versions --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Hunter Achieng <achienghunter@gmail.com> Co-authored-by: Pius Kariuki <39379012+PiusKariuki@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: hunterachieng <79210550+hunterachieng@users.noreply.github.com> Co-authored-by: Emmanuel Evance <mtuchidev@gmail.com>

hunterachieng added 2 commits May 26, 2026 15:56

feat: implement primitive mappings

31f26a3

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

feat: update comments

9fcf969

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

taylordowns2000 added this to Adaptor Development May 26, 2026

hunterachieng requested a review from josephjclark May 26, 2026 13:19

josephjclark reviewed May 27, 2026

View reviewed changes

hunterachieng added 7 commits May 27, 2026 16:17

fix tests

f444f6a

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

feat: update fhir-eswatini

976e9ee

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

fix: remove skipped tests

31cee9a

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

feat: fix primp value renaming

dbc88b1

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

fix: package.json

4264ea5

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

Merge branch 'main' of github.com:OpenFn/adaptors into feature/1557-f…

5550022

…hir-underscores Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

feat: rebuild fhir-eswatini

b7c4547

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

hunterachieng requested a review from josephjclark June 2, 2026 20:27

josephjclark reviewed Jun 4, 2026

View reviewed changes

Comment thread tools/generate-fhir/test/generate-code.test.ts Outdated

josephjclark requested changes Jun 4, 2026

View reviewed changes

Comment thread packages/fhir-eswatini/test/resources/Patient.test.ts Outdated

Comment thread tools/generate-fhir/test/generate-code.test.ts

hunterachieng added 2 commits June 5, 2026 15:17

fix: remove nested _birthTime

74ce83d

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

fix: add tests

76a0671

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

hunterachieng requested a review from josephjclark June 5, 2026 13:21

josephjclark added 2 commits June 9, 2026 10:12

clean up tests

37600c6

remove comment

200ab5f

josephjclark reviewed Jun 9, 2026

View reviewed changes

Comment thread packages/fhir-eswatini/src/builders.ts

Comment thread packages/fhir-eswatini/test/resources/Patient.test.ts

hunterachieng added 2 commits June 10, 2026 00:22

fix: add tests and update docs

d580dcd

Signed-off-by: Hunter Achieng <achienghunter@gmail.com>

Merge branch 'feature/1557-fhir-underscores' of github.com:OpenFn/ada…

3f1d68e

…ptors into feature/1557-fhir-underscores

hunterachieng requested a review from josephjclark June 9, 2026 21:24

josephjclark approved these changes Jun 30, 2026

View reviewed changes

josephjclark added 4 commits June 30, 2026 12:21

bump fhir-gen tool

45157c4

fhir-eswatini: update build meta

538d55a

changeset

fd74985

Merge branch 'feature/1557-fhir-underscores' of github.com-josephjcla…

882ddcd

…rk:OpenFn/adaptors into feature/1557-fhir-underscores

josephjclark changed the base branch from main to release/next June 30, 2026 11:26

josephjclark merged commit 605a816 into release/next Jun 30, 2026
3 checks passed

josephjclark deleted the feature/1557-fhir-underscores branch June 30, 2026 11:33

github-project-automation Bot moved this to Closed in Adaptor Development Jun 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fhir: map primitive elements#1678

fhir: map primitive elements#1678
josephjclark merged 19 commits into
release/nextfrom
feature/1557-fhir-underscores

hunterachieng commented May 26, 2026 •

edited by josephjclark

Loading

Uh oh!

josephjclark left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hunterachieng commented May 26, 2026 • edited by josephjclark Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

AI Usage

Review Checklist

Uh oh!

josephjclark left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hunterachieng commented May 26, 2026 •

edited by josephjclark

Loading