enable type checking on project tests and fix a bunch of types

Author: josephjclark

packages/lexicon/index.d.ts

@@ -1,2 +1,3 @@
 export * from './core';
+export * from './portability';
 export * as lightning from './lighting';

packages/lexicon/lightning.d.ts

@@ -285,6 +285,8 @@ export namespace Provisioner {
     inserted_at?: string;
     updated_at?: string;
     deleted_at: string | null;
+
+    positions?: Record<string, { x: number; y: number }>;
   }
 
   export type Collection = {

packages/lexicon/portability.d.ts

@@ -84,9 +84,6 @@ export interface Trigger extends Step {
     success_code?: number;
   };
   cron_cursor_job_id?: string;
-
-  /** Allow arbitrary properties on trigger nodes (as configuration options) */
-  [option: string]: any;
 }
 
 // TODO credential should just be an id string in the near future

packages/project/test/canonical.test.ts

@@ -27,7 +27,7 @@ const project: ProjectSpec = {
           type: 'webhook',
           enabled: true,
           webhook_reply: 'before_start',
-          webhook_response: {
+          webhook_response_config: {
             success_code: 202,
             error_code: 500,
           },

packages/project/test/gen/generator.test.ts

@@ -8,7 +8,7 @@ const LOG_OUTPUTS = false;
 
 // Generate a workflow with a fixed UUID seed
 // Pass test context to log the result
-const gen = (src: string, t?: ExecutionContext<unknown>, options = {}) => {
+const gen = (src: string, t?: ExecutionContext<unknown>, options = {}): any => {
   const result = generateWorkflow(src, {
     uuidSeed: 1,
     printErrors: false,
@@ -444,15 +444,15 @@ test('it should generate a webhook trigger', (t) => {
 
 test('it should generate a node with a prop', (t) => {
   const result = gen('a(expression=y)-b', t);
-  const expected = _.cloneDeep(fixtures.ab);
+  const expected: any = _.cloneDeep(fixtures.ab);
   expected.steps[0].expression = 'y';
 
   t.deepEqual(result, expected);
 });
 
 test('it should generate a node with a prop with an underscore', (t) => {
   const result = gen('a(project_credential_id=y)-b', t);
-  const expected = _.cloneDeep(fixtures.ab);
+  const expected: any = _.cloneDeep(fixtures.ab);
   expected.steps[0].openfn = {
     uuid: 1,
     project_credential_id: 'y',
@@ -486,7 +486,7 @@ test('it should save unexpected props to .openfn', (t) => {
 
 test('it should generate a node with two props', (t) => {
   const result = gen('a(adaptor=j,expression=k)-b', t);
-  const expected = _.cloneDeep(fixtures.ab);
+  const expected: any = _.cloneDeep(fixtures.ab);
   expected.steps[0].adaptor = 'j';
   expected.steps[0].expression = 'k';
 
@@ -623,40 +623,12 @@ a-b #zz
 });
 
 test('it should generate a project with seeded uuids', (t) => {
-  const result = generateProject('x', ['a-b'], {
+  const result: any = generateProject('x', ['a-b'], {
     openfnUuid: true,
     uuidSeed: 1000,
     uuid: 123,
   });
 
-  const expected = {
-    id: 'workflow',
-    name: 'Workflow',
-    history: [],
-    steps: [
-      {
-        id: 'a',
-        name: 'a',
-        openfn: {
-          uuid: 'A',
-        },
-        next: {
-          b: {
-            openfn: {
-              uuid: 'AB',
-            },
-          },
-        },
-      },
-      {
-        id: 'b',
-        name: 'b',
-        openfn: {
-          uuid: 'B',
-        },
-      },
-    ],
-  };
   t.deepEqual(result.openfn, {
     uuid: 123,
   });
@@ -710,6 +682,7 @@ test('it should generate a simple workflow with mapped uuids', (t) => {
 test('it should generate a project with mapped uuids', (t) => {
   const result = generateProject('x', ['a-b'], {
     openfnUuid: true,
+    // @ts-ignore
     uuidMap: [
       {
         a: 'A',

packages/project/test/merge/map-uuids.test.ts

@@ -1,21 +1,20 @@
-import * as l from '@openfn/lexicon';
-
 import test from 'ava';
 import mapUUIDs from '../../src/merge/map-uuids';
 import generateWorkflow from '../../src/gen/generator';
 import Workflow from '../../src/Workflow';
 
-const gen = (src) => generateWorkflow(src, { uuidSeed: 1 });
+const gen = (src: string) => generateWorkflow(src, { uuidSeed: 1 });
 
 let idgen = 0;
 
-const createSingleNode = (name, uuid) =>
+const createSingleNode = (name: string, uuid?: string | number) =>
   new Workflow({
     id: `wf-${++idgen}}`,
     steps: [
       {
         id: name,
         name,
+        // @ts-ignore
         openfn: { uuid: uuid ?? crypto.randomUUID() },
       },
     ],