Merge pull request #1138 from OpenFn/disable-retry

Disable worker retry stuff

Author: josephjclark

packages/ws-worker/CHANGELOG.md

@@ -1,5 +1,11 @@
 # ws-worker
 
+## 1.19.5
+
+### Patch Changes
+
+- b42b0b0: Force disable message retries
+
 ## 1.19.4
 
 ### Patch Changes

packages/ws-worker/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfn/ws-worker",
-  "version": "1.19.4",
+  "version": "1.19.5",
   "description": "A Websocket Worker to connect Lightning to a Runtime Engine",
   "main": "dist/index.js",
   "type": "module",

packages/ws-worker/src/start.ts

@@ -53,7 +53,7 @@ function engineReady(engine: any) {
     timeoutRetryDelayMs: args.timeoutRetryDelayMs,
   };
 
-  if ('socketTimeoutSeconds' in args) {
+  if (args.socketTimeoutSeconds) {
     logger.warn(
       'WARNING: deprecated socketTimeoutSeconds value passed.\n\nThis will be respected as the default socket timeout value, but will be removed from future versions of the worker.'
     );

packages/ws-worker/src/util/send-event.ts

@@ -2,6 +2,10 @@ import * as Sentry from '@sentry/node';
 import type { Context } from '../api/execute';
 import { LightningSocketError, LightningTimeoutError } from '../errors';
 
+// Force disabled for now because this can cause duplication on the Lightning end
+// See https://github.com/OpenFn/kit/issues/1137
+const allowRetryOntimeout = false;
+
 export const sendEvent = <T>(
   context: Pick<Context, 'logger' | 'channel' | 'id' | 'options'>,
   event: string,
@@ -48,7 +52,7 @@ export const sendEvent = <T>(
         report(new LightningSocketError(event, message));
       })
       .receive('timeout', () => {
-        if (thisAttempt >= timeoutRetryCount) {
+        if (!allowRetryOntimeout || thisAttempt >= timeoutRetryCount) {
           report(new LightningTimeoutError(event));
         } else {
           logger.warn(

packages/ws-worker/test/util/send-event.test.ts

@@ -114,7 +114,8 @@ test.serial('should throw if the event timesout and retry is 1', async (t) => {
   t.is(events.length, 0);
 });
 
-test.serial(
+// This behaviour is disabled and this test will likely be removed soon
+test.serial.skip(
   'should throw after 5 attempts if the event timesout and retry is 5',
   async (t) => {
     const EVENT_NAME = 'test';
@@ -147,7 +148,8 @@ test.serial(
   }
 );
 
-test.serial(
+// This behaviour is disabled and this test will likely be removed soon
+test.serial.skip(
   'should pass after 5 attempts if the event timesout and retry is 5',
   async (t) => {
     let count = 0;