Merge pull request #1114 from OpenFn/release/next

Release/next

Author: josephjclark

packages/cli/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @openfn/cli
 
+## 1.18.2
+
+### Patch Changes
+
+- Updated dependencies [fe06f44]
+  - @openfn/runtime@1.7.5
+
 ## 1.18.1
 
 ### Patch Changes

packages/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfn/cli",
-  "version": "1.18.1",
+  "version": "1.18.2",
   "description": "CLI devtools for the OpenFn toolchain",
   "engines": {
     "node": ">=18",

packages/engine-multi/CHANGELOG.md

@@ -1,5 +1,12 @@
 # engine-multi
 
+## 1.8.3
+
+### Patch Changes
+
+- Updated dependencies [fe06f44]
+  - @openfn/runtime@1.7.5
+
 ## 1.8.2
 
 ### Patch Changes

packages/engine-multi/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfn/engine-multi",
-  "version": "1.8.2",
+  "version": "1.8.3",
   "description": "Multi-process runtime engine",
   "main": "dist/index.js",
   "type": "module",

packages/lightning-mock/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @openfn/lightning-mock
 
+## 2.3.6
+
+### Patch Changes
+
+- Updated dependencies [fe06f44]
+  - @openfn/runtime@1.7.5
+  - @openfn/engine-multi@1.8.3
+
 ## 2.3.5
 
 ### Patch Changes

packages/lightning-mock/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfn/lightning-mock",
-  "version": "2.3.5",
+  "version": "2.3.6",
   "private": true,
   "description": "A mock Lightning server",
   "main": "dist/index.js",

packages/runtime/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @openfn/runtime
 
+## 1.7.5
+
+### Patch Changes
+
+- fe06f44: Expose Buffer to runtime context. Quite safe in node 20+
+
 ## 1.7.4
 
 ### Patch Changes

packages/runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfn/runtime",
-  "version": "1.7.4",
+  "version": "1.7.5",
   "description": "Job processing runtime.",
   "type": "module",
   "exports": {

packages/runtime/src/execute/context.ts

@@ -21,6 +21,19 @@ export default (
 ) => {
   const logger = options.jobLogger ?? console;
   const globals = options.globals || {};
+
+  // Workaround for https://github.com/nodejs/node/issues/4660
+  // The Buffer class we share directly with users will throw if used
+  // All _internal_ Buffer references use the original nodejs interface
+  class SafeBuffer extends Buffer {
+    constructor(x: any) {
+      throw new Error(
+        'Do not call Buffer() constructor directly. Use Buffer.from() instead.'
+      );
+      super(x); // keeps types happy
+    }
+  }
+
   const context = vm.createContext(
     freezeAll(
       {
@@ -34,6 +47,7 @@ export default (
         setInterval,
         setTimeout,
         state, // TODO will be dropped as a global one day, see https://github.com/OpenFn/kit/issues/17
+        Buffer: SafeBuffer,
       },
       { state: true }
     ),

packages/runtime/test/context.test.ts

@@ -60,3 +60,27 @@ test("doesn't allow eval inside a job", async (t) => {
     message: /Illegal eval statement detected/,
   });
 });
+
+test('Buffer.from() works inside a job', async (t) => {
+  const expression = `
+    export default [
+      (s) => { s.data = Buffer.from('6a6f65', 'hex').toString(); return s;  }
+    ];`;
+  const input = {};
+
+  const result = await run(expression, input);
+  t.is(result.data as any, 'joe');
+});
+
+test('Buffer constructor throws inside a job', async (t) => {
+  const expression = `
+    export default [
+      (s) => { s.data = new Buffer('6a6f65', 'hex').toString(); return s;  }
+    ];`;
+  const input = {};
+
+  const result = await run(expression, input);
+  const err = result.errors!['job-1'];
+  t.is(err.name, 'JobError');
+  t.regex(err.message, /do not call Buffer\(\) constructor/i);
+});