Skip to content

Commit a4bf144

Browse files
committed
runtime: update tests
1 parent c6e6741 commit a4bf144

2 files changed

Lines changed: 7 additions & 14 deletions

File tree

packages/runtime/src/util/sourcemap-errors.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,9 @@ export default async (job: Job, error: RTError) => {
2727

2828
if (error.pos && !isNaN(error.pos.line!)) {
2929
const fileName = job.name ? `${job.name}.js` : 'src.js';
30-
try {
31-
const src = smc.sourceContentFor(fileName)!.split('\n');
32-
const line = src[error.pos.line! - 1];
33-
error.pos.src = line;
34-
} catch (e) {
35-
console.debug(
36-
`Failed to load sourcemap for "${fileName}", falling back to default error`
37-
);
38-
console.error(e);
39-
}
30+
const src = smc.sourceContentFor(fileName)!.split('\n');
31+
const line = src[error.pos.line! - 1];
32+
error.pos.src = line;
4033
}
4134
}
4235
};

packages/runtime/test/util/sourcemap-errors.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import { RTError } from '../../src';
66
const b = recast.types.builders;
77

88
// compile an expression into a function
9-
const compile = (src: string) => {
9+
const compile = (src: string, sourceFileName = 'src.js') => {
1010
const ast = recast.parse(src, {
11-
sourceFileName: 'src.js',
11+
sourceFileName,
1212
});
1313

1414
// take the expression and wrap it in a function declaration
@@ -22,12 +22,12 @@ const compile = (src: string) => {
2222
ast.program.body.push(fn);
2323

2424
return recast.print(fn, {
25-
sourceMapName: 'src.map.js',
25+
sourceMapName: `${sourceFileName.replace('.js', '.map.js')}`,
2626
});
2727
};
2828

2929
test('should write the step name to the error', async (t) => {
30-
const { code, map } = compile('x + 1');
30+
const { code, map } = compile('x + 1', 'yyy.js');
3131

3232
// create a fake job
3333
const job = {

0 commit comments

Comments
 (0)