Update to Node 24 (#1331)

* version

* update asdf

* bump pnpm

* update CI versions

* increase cli test timeout

* runtime: tweak linker to prefer ESM support

* runtime: even better exports tracking

After working with claude and closely tracking the docs

* skip tests which won#t run on node24

* update tests

* update tests

* remove lightning mock stuff

* Node24: add custom module loader for back-compat with older modules (#1343)

* add a custom module loader to handle older imports without .js extensions

* types

* typo

* fix module loader path

* fix module import and update tests

* use esmhook in metadata

* remove stupid logging

* remove debug flag from tests

* add more mock paths

* fix test

* update module path

* format

* use unidici fetch, not native fetch

Hoping this will fix failures in CI

* types

* tests: fix error messages

Author: josephjclark

.changeset/plain-taxis-prove.md

@@ -0,0 +1,6 @@
+---
+'@openfn/runtime': minor
+---
+
+- Enable full compatibility with node 24
+- When loading modules, prefer ESM targets over CJS targets

.circleci/config.yml

@@ -7,7 +7,7 @@ jobs:
     # Specify the execution environment. You can specify an image from Dockerhub or use one of our Convenience Images from CircleCI's Developer Hub.
     # See: https://circleci.com/docs/2.0/configuration-reference/#docker-machine-macos-windows-executor
     docker:
-      - image: cimg/node:22.20
+      - image: cimg/node:24.14
     resource_class: medium
     # Add steps to the job
     # See: https://circleci.com/docs/2.0/configuration-reference/#steps
@@ -35,7 +35,7 @@ jobs:
 
   build:
     docker:
-      - image: cimg/node:22.20
+      - image: cimg/node:24.14
     resource_class: medium
     steps:
       - attach_workspace:
@@ -50,7 +50,7 @@ jobs:
 
   unit_test:
     docker:
-      - image: cimg/node:22.20
+      - image: cimg/node:24.14
     resource_class: medium
     parallelism: 1
     steps:
@@ -62,7 +62,7 @@ jobs:
 
   format:
     docker:
-      - image: cimg/node:22.20
+      - image: cimg/node:24.14
     resource_class: medium
     steps:
       - attach_workspace:
@@ -73,7 +73,7 @@ jobs:
 
   type_check:
     docker:
-      - image: cimg/node:22.20
+      - image: cimg/node:24.14
     resource_class: medium
     steps:
       - attach_workspace:
@@ -131,6 +131,6 @@ workflows:
       - integration_test:
           matrix:
             parameters:
-              node_version: ['22.20']
+              node_version: ['22.20', '24.14.0']
           requires:
             - build

.github/workflows/project-integration-tests.yaml

@@ -14,15 +14,15 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.label.name == 'run_project_tests'
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - name: Checkout Integration Test Repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           repository: openfn/project-integration-tests
           path: resources/repo
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v6
         with:
-          node-version: '22.12'
+          node-version: '24.14'
       - uses: pnpm/action-setup@v4
       - run: pnpm install
       - run: pnpm install:openfnx

.github/workflows/publish.yaml

@@ -15,7 +15,7 @@ jobs:
           fetch-depth: 1
       - uses: actions/setup-node@v6
         with:
-          node-version: '22.12'
+          node-version: '24.14'
       - uses: pnpm/action-setup@v4
       - run: pnpm install
       - run: pnpm build

.tool-versions

@@ -1 +1 @@
-nodejs 22.12.0
+nodejs 24.14.0

integration-tests/cli/modules/test/package.json

@@ -2,7 +2,7 @@
   "name": "@openfn/language-test",
   "version": "0.0.1",
   "type": "module",
-  "module": "index.js",
+  "main": "index.js",
   "private": true,
   "devDependencies": {}
 }

integration-tests/cli/test/autoinstall.test.ts

@@ -79,11 +79,22 @@ test.serial(
   }
 );
 
+/***
+ * Important: these tests are skipped because the old @openfn/language-testing package,
+ * which has been deprecated and removed from adaptors repo, depends on a version of
+ * language-common which just happens to be incompatible with node24
+ *
+ * Since the pre-release stuff is sitting unreleased these tests will just sit on skipped
+ * We should work out how to build a new version of this package (not in the adaptors repo)
+ * And probably remove the common dependency
+ */
+
 // Ignore the @next version if present but we asked for latest
-test.serial(
+test.serial.skip(
   `openfn ${jobsPath}/simple.js -a testing@latest ${repoDir} ${log}`,
   async (t) => {
     const { stdout, err } = await run(t.title);
+    console.log(stdout);
 
     // t.falsy(err); // TODO I think this is a broken adaptor build?
     t.regex(stdout, /Auto-installing language adaptors/);
@@ -109,7 +120,7 @@ test.serial(
 );
 
 // Ignore @next if present but we asked for no version
-test.serial(
+test.serial.skip(
   `openfn ${jobsPath}/simple.js -a testing ${repoDir} ${log}`,
   async (t) => {
     const { stdout, err } = await run(t.title);
@@ -126,7 +137,7 @@ test.serial(
 
 // TODO we need to fix the version of testing
 // maybe after release we can push next onto 2.0 and leave latest on 1.0
-test.serial(
+test.serial.skip(
   `openfn ${jobsPath}/simple.js -a testing@next ${repoDir} ${log}`,
   async (t) => {
     const { stdout, stderr } = await run(t.title);

integration-tests/cli/test/deploy.v2.test.ts

@@ -140,7 +140,7 @@ test.serial('pull a project', async (t) => {
   t.regex(yaml, /id\: test-project/);
 });
 
-test.serial.only('pull, change and re-deploy', async (t) => {
+test.serial('pull, change and re-deploy', async (t) => {
   const projectId = 'aaaaaaaa';
   server.addProject(makeProject(projectId) as any);
 

integration-tests/cli/test/errors.test.ts

@@ -158,7 +158,7 @@ test.serial('job with reference error', async (t) => {
     'ref aborted with error (SSSms)',
     `TypeError: Cannot read properties of undefined (reading 'y')
     at vm:module(0):1:23
-    @openfn/language-common_2.1.1/dist/index.cjs:333:12`,
+    @openfn/language-common_2.1.1/dist/index.js:270:12`,
     'Error occurred at: ref',
     '1: fn((state) => state.x.y)',
     '                         ^ ',
@@ -178,7 +178,7 @@ test.serial('job with not a function error', async (t) => {
     'not-function aborted with error (SSSms)',
     `TypeError: state is not a function
     at vm:module(0):1:15
-    @openfn/language-common_2.1.1/dist/index.cjs:333:12`,
+    @openfn/language-common_2.1.1/dist/index.js:270:12`,
     'Error occurred at: not-function',
     '1: fn((state) => state())',
     '                 ^       ',
@@ -198,7 +198,7 @@ test.serial('job with assign-to-const error', async (t) => {
     'assign-const aborted with error (SSSms)',
     `TypeError: Assignment to constant variable.
     at vm:module(0):1:33
-    @openfn/language-common_2.1.1/dist/index.cjs:333:12`,
+    @openfn/language-common_2.1.1/dist/index.js:270:12`,
     'Error occurred at: assign-const',
     '1: fn((state) => {  const x = 10; x = 20; })',
     '                                   ^        ',

integration-tests/worker/.tool-versions

@@ -0,0 +1 @@
+nodejs 24.14.0