Skip to content

Workspace: getActiveProject is dangerously misleading! #1359

@josephjclark

Description

@josephjclark

@doc-han stumbled across a huge issue in the Workspace class.

getActiveProject should really be something like getTrackedProject, because it returns the project.yaml representation of the checked out project, not what's on the filesystem.

Workspace already exposes getCheckedOutProject, which is fine

We need to:

  1. Rename the function
  2. Check all uses of the function and check whether they should use getCheckedOutProject instead (the checkout CLI stuff certainly does)

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingsync v2

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions