Open
Conversation
Collaborator
Author
|
claude may have found a gap which can cause problems - but that fix doesn't help the actual problem |
josephjclark
force-pushed
the
investigate-flaky-tests
branch
from
b75de8c to
9b223c2
Compare
I think this this fixes the actual issue - I just want more good focused tests now
josephjclark
changed the title
Collaborator
Author
|
I'll fix the build and typings in the morning 😫 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Fixes #1350
See issue
Implementation Details
Ok so I don't know the exact case that's causing intermittend fails - but what I've done is manually re-write the tests for the event processor in a much more unit testy way. This divorces the event processor from the runtime and lets me have much more control over tests, so I can recreate particular scenarios more reliably.
The more integration style tests, involving the engine, are still useful - so they're in.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy