Migrate rake task constants to class methods

Author: eliotjordan

.rubocop.yml

@@ -14,3 +14,7 @@ AllCops:
 
 RSpec/DescribeClass:
   Enabled: false
+
+RSpec/BeforeAfterAll:
+  Exclude:
+    - 'spec/lib/tasks/geo_combine_spec.rb'

lib/tasks/geo_combine.rake

@@ -7,18 +7,6 @@ require 'find'
 require 'geo_combine/geo_blacklight_harvester'
 
 namespace :geocombine do
-  commit_within = (ENV['SOLR_COMMIT_WITHIN'] || 5000).to_i
-  ogm_path = ENV['OGM_PATH'] || 'tmp/opengeometadata'
-  solr_url = ENV['SOLR_URL'] || 'http://127.0.0.1:8983/solr/blacklight-core'
-  denylist = [
-    'https://github.com/OpenGeoMetadata/GeoCombine.git',
-    'https://github.com/OpenGeoMetadata/aardvark.git',
-    'https://github.com/OpenGeoMetadata/metadata-issues.git',
-    'https://github.com/OpenGeoMetadata/ogm_utils-python.git',
-    'https://github.com/OpenGeoMetadata/opengeometadata.github.io.git',
-    'https://github.com/OpenGeoMetadata/opengeometadata-rails.git'
-  ]
-
   desc 'Clone OpenGeoMetadata repositories'
   task :clone, [:repo] do |_t, args|
     if args.repo
@@ -28,19 +16,19 @@ namespace :geocombine do
       ogm_repos = JSON.parse(Net::HTTP.get(ogm_api_uri)).map do |repo|
         repo['clone_url'] if (repo['size']).positive?
       end.compact
-      ogm_repos.reject! { |repo| denylist.include?(repo) }
+      ogm_repos.reject! { |repo| GeoCombineRake.denylist.include?(repo) }
     end
     ogm_repos.each do |repo|
-      Kernel.system "echo #{repo} && mkdir -p #{ogm_path} && cd #{ogm_path} && git clone --depth 1 #{repo}"
+      Kernel.system "echo #{repo} && mkdir -p #{GeoCombineRake.ogm_path} && cd #{GeoCombineRake.ogm_path} && git clone --depth 1 #{repo}"
     end
   end
 
   desc '"git pull" OpenGeoMetadata repositories'
   task :pull, [:repo] do |_t, args|
     paths = if args.repo
-              [File.join(ogm_path, args.repo)]
+              [File.join(GeoCombineRake.ogm_path, args.repo)]
             else
-              Dir.glob("#{ogm_path}/*")
+              Dir.glob("#{GeoCombineRake.ogm_path}/*")
             end
     paths.each do |path|
       next unless File.directory?(path)
@@ -51,15 +39,15 @@ namespace :geocombine do
 
   desc 'Index all JSON documents except Layers.json'
   task :index do
-    puts "Indexing #{ogm_path} into #{solr_url}"
-    solr = RSolr.connect url: solr_url, adapter: :net_http_persistent
-    Find.find(ogm_path) do |path|
+    puts "Indexing #{GeoCombineRake.ogm_path} into #{GeoCombineRake.solr_url}"
+    solr = RSolr.connect url: GeoCombineRake.solr_url, adapter: :net_http_persistent
+    Find.find(GeoCombineRake.ogm_path) do |path|
       next unless File.basename(path).include?('.json') && File.basename(path) != 'layers.json'
 
       doc = JSON.parse(File.read(path))
       [doc].flatten.each do |record|
         puts "Indexing #{record['layer_slug_s']}: #{path}" if $DEBUG
-        solr.update params: { commitWithin: commit_within, overwrite: true },
+        solr.update params: { commitWithin: GeoCombineRake.commit_within, overwrite: true },
                     data: [record].to_json,
                     headers: { 'Content-Type' => 'application/json' }
       rescue RSolr::Error::Http => e
@@ -78,3 +66,29 @@ namespace :geocombine do
     end
   end
 end
+
+# Class to hold helper methods for use in GeoCombine rake tasks
+class GeoCombineRake
+  def self.commit_within
+    (ENV['SOLR_COMMIT_WITHIN'] || 5000).to_i
+  end
+
+  def self.denylist
+    [
+      'https://github.com/OpenGeoMetadata/GeoCombine.git',
+      'https://github.com/OpenGeoMetadata/aardvark.git',
+      'https://github.com/OpenGeoMetadata/metadata-issues.git',
+      'https://github.com/OpenGeoMetadata/ogm_utils-python.git',
+      'https://github.com/OpenGeoMetadata/opengeometadata.github.io.git',
+      'https://github.com/OpenGeoMetadata/opengeometadata-rails.git'
+    ]
+  end
+
+  def self.ogm_path
+    ENV['OGM_PATH'] || 'tmp/opengeometadata'
+  end
+
+  def self.solr_url
+    ENV['SOLR_URL'] || 'http://127.0.0.1:8983/solr/blacklight-core'
+  end
+end

spec/lib/tasks/geo_combine_spec.rb

@@ -4,15 +4,18 @@
 require 'rake'
 
 describe 'geo_combine.rake' do
+  before(:all) do
+    load File.expand_path('../../../lib/tasks/geo_combine.rake', __dir__)
+    Rake::Task.define_task(:environment)
+  end
+
   before do
     allow(ENV).to receive(:[]).and_call_original
     allow(ENV).to receive(:[]).with('OGM_PATH').and_return(File.join(fixture_dir, 'indexing'))
   end
 
   describe 'geocombine:clone' do
     before do
-      load File.expand_path('../../../lib/tasks/geo_combine.rake', __dir__)
-      Rake::Task.define_task(:environment)
       WebMock.disable_net_connect!
     end