Merge pull request #123 from OpenGeoMetadata/deny-list

move to a denylist for the cloning since not everyone is naming with …

Author: tpendragon

.rubocop.yml

@@ -11,3 +11,6 @@ AllCops:
   Exclude:
   - 'geo_combine.gemspec'
   - 'tmp/**/*'
+
+RSpec/DescribeClass:
+  Enabled: false

.rubocop_todo.yml

@@ -78,11 +78,16 @@ RSpec/FilePath:
   Exclude:
     - 'spec/lib/geo_combine_spec.rb'
 
-# Offense count: 23
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
-  EnforcedStyle: receive
+  EnforcedStyle: have_received
+  Exclude:
+    - 'spec/lib/geo_combine/esri_open_data_spec.rb'
+    - 'spec/lib/geo_combine/geo_blacklight_harvester_spec.rb'
+    - 'spec/lib/geo_combine/geoblacklight_spec.rb'
+    - 'spec/lib/geo_combine/ogp_spec.rb'
+    - 'spec/lib/geo_combine_spec.rb'
 
 # Offense count: 39
 RSpec/MultipleExpectations:

geo_combine.gemspec

@@ -34,4 +34,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop-rspec', '~> 2.8'
   spec.add_development_dependency 'rubocop-rake'
   spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'webmock', '~> 3.14'
 end

lib/tasks/geo_combine.rake

@@ -10,8 +10,13 @@ namespace :geocombine do
   commit_within = (ENV['SOLR_COMMIT_WITHIN'] || 5000).to_i
   ogm_path = ENV['OGM_PATH'] || 'tmp/opengeometadata'
   solr_url = ENV['SOLR_URL'] || 'http://127.0.0.1:8983/solr/blacklight-core'
-  whitelist = %w[
-    https://github.com/OpenGeoMetadata/big-ten.git
+  denylist = [
+    'https://github.com/OpenGeoMetadata/GeoCombine.git',
+    'https://github.com/OpenGeoMetadata/aardvark.git',
+    'https://github.com/OpenGeoMetadata/metadatarepository.git',
+    'https://github.com/OpenGeoMetadata/ogm_utils-python.git',
+    'https://github.com/OpenGeoMetadata/opengeometadata.github.io.git',
+    'https://github.com/OpenGeoMetadata/opengeometadata-rails.git'
   ]
 
   desc 'Clone OpenGeoMetadata repositories'
@@ -23,10 +28,10 @@ namespace :geocombine do
       ogm_repos = JSON.parse(Net::HTTP.get(ogm_api_uri)).map do |repo|
         repo['clone_url'] if (repo['size']).positive?
       end.compact
-      ogm_repos.select! { |repo| whitelist.include?(repo) || repo =~ /(edu|org|uk)\..*\.git$/ }
+      ogm_repos.reject! { |repo| denylist.include?(repo) }
     end
     ogm_repos.each do |repo|
-      system "echo #{repo} && mkdir -p #{ogm_path} && cd #{ogm_path} && git clone --depth 1 #{repo}"
+      Kernel.system "echo #{repo} && mkdir -p #{ogm_path} && cd #{ogm_path} && git clone --depth 1 #{repo}"
     end
   end
 
@@ -40,7 +45,7 @@ namespace :geocombine do
     paths.each do |path|
       next unless File.directory?(path)
 
-      system "echo #{path} && cd #{path} && git pull origin"
+      Kernel.system "echo #{path} && cd #{path} && git pull origin"
     end
   end
 

spec/fixtures/docs/repos.json

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'rake'
+
+describe 'geo_combine.rake' do
+  before do
+    load('lib/tasks/geo_combine.rake')
+  end
+
+  describe 'geocombine:clone' do
+    before do
+      WebMock.disable_net_connect!
+    end
+
+    after do
+      WebMock.allow_net_connect!
+    end
+
+    it 'does not clone repos on deny list' do
+      stub_request(:get, 'https://api.github.com/orgs/opengeometadata/repos').to_return(status: 200, body: read_fixture('docs/repos.json'))
+      allow(Kernel).to receive(:system)
+      Rake::Task['geocombine:clone'].invoke
+      expect(Kernel).to have_received(:system).exactly(20).times
+    end
+  end
+end

spec/lib/tasks/geo_combine_spec.rb

@@ -18,6 +18,13 @@
 require 'rspec-html-matchers'
 require 'byebug'
 
+# Setup webmock for specific tests
+require 'webmock/rspec'
+WebMock.allow_net_connect!
+
+# include the spec support files
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
+
 RSpec.configure do |config|
   config.include Helpers
   config.include RSpecHtmlMatchers

spec/spec_helper.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+def read_fixture(fname)
+  File.read(File.join(fixture_dir, fname))
+end
+
+def fixture_dir
+  @fixture_dir ||= File.join(File.dirname(__FILE__), '../fixtures')
+end